After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 565913 - Please add a "button group" geometry model
Please add a "button group" geometry model
Status: RESOLVED OBSOLETE
Product: metacity
Classification: Other
Component: themes
2.24.x
Other All
: Normal enhancement
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks: 482165
 
 
Reported: 2008-12-29 09:02 UTC by Screwtape
Modified: 2020-11-07 12:36 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement



Description Screwtape 2008-12-29 09:02:35 UTC
Currently metacity themes model title-bar buttons as identical, uniform rectangles: Every button has exactly the same shape and exactly the same borders no matter where it is on the titlebar. This is a reasonable compromise between code simplicity and visual flexibility, but there are some fairly common circumstances where this model is too limiting.

Consider the situation where the artist wants to have a collection of buttons grouped together, something like this:

    ( _|[]|X )

The left-most button would require more room on the left to render the rounded end-cap, the right-most button would require more room on the right, and the middle button requires no extra room. Under the current scheme all three buttons would have the same geometry, meaning that either the middle button is swimming in space or the outer buttons look cramped.

I propose adding a new set of values for the 'name' attribute of the <border> element in <frame_geometry>:

 - left_left_button_border
   Used for the left-most button at the left of the title, when there are two or more buttons there.
 - left_middle_button_borde
   Used for the inner buttons at the left of the title, when there are three or more buttons there.
 - left_right_button_border
   Used for the right-most button at the left of the title, when there are two or more buttons there.
 - left_only_button_border
   Used when there is only one button to the left of the title.
 - right_left_button_border
   Used for the left-most button at the right of the title, when there are two or more buttons there.
 - right_middle_button_border
   Used for the inner buttons at the right of the title, when there are three or more buttons there.
 - right_right_button_border
   Used for the right-most button at the right of the title, when there are two or more buttons there.
 - right_only_button_border
   Used when there is only one button to the right of the title.

You might recognise this naming scheme from the *_background button functions in the frame_style element. For maximum flexibility, there should be left_only_background and right_only_background button functions too.

Note that this is not really useful until the various *_background button functions work reliably (see bug 401726 and bug 419125)
Comment 1 Thomas Thurman 2009-02-03 15:29:39 UTC
I like this idea.  Policy dictates that changes to the theme format require a new version number, though, so I'm setting it to block v3 of the format.
Comment 2 André Klapper 2020-11-07 12:36:31 UTC
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all
old feature requests in Bugzilla which have not seen updates for many years.

If you still use metacity and if you are still requesting this feature in a currently supported version of GNOME (currently that would be 3.38), then please feel free to report it at https://gitlab.gnome.org/GNOME/metacity/-/issues/

Thank you for reporting this issue and we are sorry it could not be implemented.