GNOME Bugzilla – Bug 565593
PyGTK 2.13.0 'make check' fails with Python 2.6 due to ihooks issue
Last modified: 2009-05-02 13:17:12 UTC
Please describe the problem: See summary. Due to Python issue #4244, I think - http://bugs.python.org/issue4244 - doing 'make check' after building PyGTK 2.13.0 against Python 2.6 fails: make[2]: Entering directory `/home/mandrake/rpm/BUILD/pygtk-2.13.0/tests' Traceback (most recent call last):
+ Trace 211053
srcDir=srcDir)
atk = importModule('atk', buildDir)
obj = __import__(module, {}, {}, fromlist)
q, tail = self.find_head_package(parent, str(name))
q = self.import_it(head, qname, parent)
m = self.loader.load_module(fqname, stuff)
m = self.hooks.load_dynamic(name, filename, file)
return ihooks.Hooks.load_dynamic(self, name, filename, file)
return imp.load_dynamic(name, filename, file)
Upstream seem to say that you shouldn't use ihooks any more: "ihooks is undocumented and deprecated, so I doubt anything will be done about that." so pygtk should stop using it, I guess. Or fix this issue somehow. Steps to reproduce: 1. Build PyGTK 2.13.0 against Python 2.6 2. Try and run 'make check' 3. Actual results: Error above. Expected results: Successful check. Does this happen every time? Yes. Other information:
*** Bug 570281 has been marked as a duplicate of this bug. ***
Could someone clarify whether this is a bug in the test suite or in pygobject itself? "Can't even pass its own self-tests on multiple platforms" is hella-serious-sounding, but if it's "only" because the test itself is broken, I'd feel more comfortable deploying it to my users.
Following up myself, pygobject itself is what appears to completely unusable with python26 (per Bug #577870) not just a self-test problem.
(In reply to comment #2) "Can't even pass its own self-tests on multiple platforms" is > hella-serious-sounding, but if it's "only" because the test itself is broken, This is open source my friend, if you feel like something is broken see if you can help, not everyone cat test things on multiple platforms, e.g. I can't.
*** Bug 577870 has been marked as a duplicate of this bug. ***
ihooks is not present in python3, so could backport some of the work happening for Bug #566641 to get around this API problem. Presently http://github.com/philn/pygobject/blob/d7159d92a276a2a1be0466700072c0896e72a82b/ltihooks.py has a work-around/alternate solution for python3 and leaves python2 using the ihooks approach. I don't know enough python to say how much of the python3 solution is directly (or even conceptually with tweaks) amenable to python2.
Created attachment 132785 [details] [review] patch for pygobject This is a patch to completely get rid of 'ltihooks.py' for PyGObject. If it works, creating a similar patch for PyGTK is not a problem. According to results of my investigation, 'ltihooks.py' is actually needed only for one thing: be able to import C modules built in the source tree, but not yet installed. If the script is removed, the same can be achieved by creating symbolic links for '.so' files from '.libs' directories to one level up. I'm not sure if what I created is a good / best possible approach, but at least it does (seem) to work fine. There is some unfortunate duplication of code between the various 'Makefile.am', but I don't see how to do without it.
Not closing the bug yet, waiting for a patch for PyGTK.
Similar patch for PyGTK is committed.