After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 565567 - dia crashes when it fails to create a new object
dia crashes when it fails to create a new object
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: objects
devel
Other All
: Normal normal
: 0.97
Assigned To: Sameer D. Sahasrabuddhe
Dia maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-24 18:15 UTC by Sameer D. Sahasrabuddhe
Modified: 2009-01-02 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the create_tool checks whether an object was created before adding it to the diagram (3.24 KB, patch)
2008-12-24 18:21 UTC, Sameer D. Sahasrabuddhe 		none Details | Review

Description Sameer D. Sahasrabuddhe 2008-12-24 18:15:38 UTC 
This is meant to track a patch posted earlier on the list. The create_tool can crash if a new DiaObject is not created. This was partially fixed in revision 3716.
Comment 1 Sameer D. Sahasrabuddhe 2008-12-24 18:21:58 UTC 
Created attachment 125273 [details] [review]
the create_tool checks whether an object was created before adding it to the diagram

This patch is different from the one posted on the mailing list. Removed an incorrect change in the original patch that replaced a call to g_return_if_fail() with a runtime check.
Comment 2 Hans Breuer 2009-01-02 14:07:30 UTC 
a slightly modified version got commited. Instead of g_warn_if_reached() - which is only available with very recent GLib - I've used Dia's message_error().

2009-01-02  Hans Breuer  <hans@breuer.org>

	* app/create_object.c : don't crash if object creation fails
	(bug #565567,  Sameer D. Sahasrabuddhe)