GNOME Bugzilla – Bug 565365
Can't add new categorie with SQLite backend
Last modified: 2018-07-11 22:56:47 UTC
Can't add new categorie with SQLite backend.
Confirming. Only possible categories are Family, Personal, Project, Work There should the possibility to manage categories at the Local File tab in the preferences.
Created attachment 129911 [details] [review] Patch to implement the feature Let's say, theoretically, I wanted this feature as well. This patch would be how I might do it. Questions: 1) I've added a reusable set of classes for "configuring categories" (ICategoryEditorView, ICategoryRepository, CategoryEditorPresenter), but since I only needed them for the Sqlite backend, left them in that namespace. Should I promote them to the general Tasque namespace? 2) Ideally, I would like to unit test CategoryEditorPresenter, and TaskCountHelper, but there's no existing unit test setup in Tasque. Any objections/opinions on me adding a tests/ toplevel directory with an NUNit setup? (Might also use NMock or Rhino.Mocks for a mock framework for testing) 3) If I screwed up on any code style things, I apologize. Let me know.
Created attachment 129947 [details] [review] Updated patch with a few file locations changed, and a unit test. Ok, Here's a version that: 1) Puts a few of the new files in a common location. 2) Adds a basic unit test to CategoryEditorPresenter. I didn't end up testing TaskCountHelper, since it uses gtk# foo (TreeModel, TreeIter, etc) and didn't want to deal with the hassles of properly unit testing GUI shtuff. Thoughts?
Okay, no chance to review yet, but to answer some questions: * Yes, setting up NUnit tests is very desirable. I'm not a big fan of using a mock library, but I concede that it might be necessary given how much our backends and business logic are intertwined with GUI code. * Coding style is sadly different in any random set of files. http://live.gnome.org/Tasque/CodingGuidelines is really not specific enough. Try to follow the style of the surrounding code, and when in doubt, refer to the Mono coding guidelines. Thanks for reminding me that we need to fix this! Will look at this as soon as I can.
Created attachment 129950 [details] [review] Updated patch with a few style fixes, and added a toplevel "test" make target. I fixed a couple style issues, added some info to the configure output about whether or not tests can be built, and added a toplevel 'test' make target.
Created attachment 130140 [details] [review] Added bin/ directory to diff. (contains Rhino.Mocks.dll) This includes the new bin/ directory, which right now just has the Rhino.Mocks.dll (the diff doesn't actually include the dll, but it was pulled from the 3.5 zip file from the Rhino.Mocks website).
*** Bug 586261 has been marked as a duplicate of this bug. ***
*** Bug 590328 has been marked as a duplicate of this bug. ***
Setting component to "Local / Sqlite". Sorry for the spam
Sorry for the spam. Setting milestone to 0.1.11 aka "Enhancements Release"
Beware! New wave of spam! Changing severity to enhancement.
Tasque is not under active development anymore and has not seen code changes for five years, and both its mailing lists have seen their last activity three years ago at https://mail.gnome.org/archives/tasque-list/ and https://groups.google.com/forum/#!forum/tasky Its codebase has been archived: https://gitlab.gnome.org/Archive/tasque/commits/master Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.