After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 565203 - RTL locales: icons are misplaced when horizontal gtkiconview is contained in a gtkscrolledwindow
RTL locales: icons are misplaced when horizontal gtkiconview is contained in ...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkIconView
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: Hebrew
 
 
Reported: 2008-12-20 20:01 UTC by Yair Hershkovitz
Modified: 2008-12-21 08:21 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
fix icon position calculation for RTL locales (1.03 KB, patch)
2008-12-20 20:34 UTC, Yair Hershkovitz 		committed Details | Review

Description Yair Hershkovitz 2008-12-20 20:01:27 UTC 
When calculation icon position allocation width (visibale area) is used instead of full (required for displaying all icons) width. When the scrollbar is needed then this causes the anchor location for displaying icons to be negative and
it is not possible to view all icons.
Comment 1 Yair Hershkovitz 2008-12-20 20:03:27 UTC 
affected applications includes cheese and eog
Comment 2 Yair Hershkovitz 2008-12-20 20:34:02 UTC 
Created attachment 125063 [details] [review]
fix icon position calculation for RTL locales

Notice that it is invalid to use priv->width in the calculation as it is going to be updated with the value of maximum_width
Comment 3 Matthias Clasen 2008-12-21 07:04:10 UTC 
Looks right.
Comment 4 Yair Hershkovitz 2008-12-21 08:12:11 UTC 
Commited on trunk. Should this also be commited on gtk-2-14?

2008-12-21  Yair Hershkovitz  <yairhr@gmail.com>

        Bug 565203: RTL locales: icons are misplaced when horizontal 
                    gtkiconview is contained in a gtkscrolledwindow.

        * gtk/gtkiconview.c (gtk_icon_view_layout_single_row):
        Fix horizontal icon positions when in RTL locale.
Comment 5 Matthias Clasen 2008-12-21 08:18:15 UTC 
Thanks. And yes, please commit to gtk-2-14 too.
Comment 6 Yair Hershkovitz 2008-12-21 08:21:14 UTC 
Commited on gtk-2-14.