After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564854 - Allow the custom widget in print dialog to actualize itself according to printer change
Allow the custom widget in print dialog to actualize itself according to prin...
Product: gtk+
Classification: Platform
Component: Printing
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Depends on:
Blocks: 549039
Reported: 2008-12-17 13:06 UTC by Marek Kašík
Modified: 2009-06-16 18:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

the patch (6.27 KB, patch)
2008-12-17 13:14 UTC, Marek Kašík
needs-work Details | Review
modified patch (4.91 KB, patch)
2009-03-24 14:36 UTC, Marek Kašík
committed Details | Review

Description Marek Kašík 2008-12-17 13:06:17 UTC
There is no way to actualize custom widget in GtkPrintUnixDialog when the selected printer has changed.
There should be a signal which brings at least GtkPageSetup and GtkPrintSettings with itself.

I'll upload patch soon.

Comment 1 Marek Kašík 2008-12-17 13:14:33 UTC
Created attachment 124861 [details] [review]
the patch

This patch adds "update-custom-widget" signal, which brings actual page setup and print settings with itself.

Comment 2 Christian Persch 2008-12-17 15:08:15 UTC
I don't think you need the "printer-changed" signal on GtkPrintUnixDialog, it should be enough to fix the selected-printer property by actually notifying when it changes (same place as your emit), and then you can connect to notify:: for it.
Comment 3 Matthias Clasen 2008-12-21 06:57:39 UTC
I think Christian is right, we can do without ::printer-changed
Comment 4 Marek Kašík 2009-03-24 14:36:04 UTC
Created attachment 131263 [details] [review]
modified patch

I'm sorry for late response.
This patch uses notify:: signal.


Comment 5 Matthias Clasen 2009-03-25 04:40:01 UTC
That patch looks fine to me, please commit once we branch.
Comment 6 Matthias Clasen 2009-04-18 19:31:35 UTC
Please commit to master