GNOME Bugzilla – Bug 564718
gtk-vnc build fail on firefox 3.x
Last modified: 2010-03-22 12:06:52 UTC
Please describe the problem: Solaris now has firefox 3.1, this cause gtk-vnc build fail against it. /opt/SUNWspro/bin/cc -DHAVE_CONFIG_H -I. -I.. -I../src -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/X11/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/firefox/java -I/usr/include/firefox/plugin -I/usr/include/firefox -I/usr/include/firefox/stable -I/usr/include/firefox/xpcom -I/usr/include/firefox/pref -I/usr/include/firefox/string -I/usr/include/firefox/expat -I/usr/include/firefox/nspr -I/usr/include/firefox/gtkembedmoz -g -c gtk-vnc-plugin.c -KPIC -DPIC -o .libs/gtk_vnc_plugin_la-gtk-vnc-plugin.o "gtk-vnc-plugin.h", line 48: syntax error before or at: uint16 "gtk-vnc-plugin.h", line 50: syntax error before or at: int32 "gtk-vnc-plugin.h", line 64: warning: no explicit type given "gtk-vnc-plugin.h", line 64: syntax error before or at: GtkVNCXHandleEvent "gtk-vnc-plugin.h", line 64: warning: old-style declaration or incorrect type for: GtkVNCXHandleEvent "gtk-vnc-plugin.c", line 168: undefined symbol: NPSetWindowCallbackStruct "gtk-vnc-plugin.c", line 168: undefined symbol: ws_info "gtk-vnc-plugin.c", line 180: syntax error before or at: ) "gtk-vnc-plugin.c", line 183: improper member use: window "gtk-vnc-plugin.c", line 184: improper member use: x "gtk-vnc-plugin.c", line 185: improper member use: y "gtk-vnc-plugin.c", line 186: improper member use: width "gtk-vnc-plugin.c", line 187: improper member use: height "gtk-vnc-plugin.c", line 192: improper member use: window "gtk-vnc-plugin.c", line 193: improper member use: x "gtk-vnc-plugin.c", line 194: improper member use: y "gtk-vnc-plugin.c", line 195: improper member use: width "gtk-vnc-plugin.c", line 196: improper member use: height "gtk-vnc-plugin.c", line 278: warning: old-style declaration or incorrect type for: int16 "gtk-vnc-plugin.c", line 279: syntax error before or at: GtkVNCXHandleEvent "gtk-vnc-plugin.c", line 279: warning: old-style declaration or incorrect type for: GtkVNCXHandleEvent "gtk-vnc-plugin.c", line 302: undefined struct/union member: ws_info "gtk-vnc-plugin.c", line 302: warning: improper pointer/integer combination: op "=" cc: acomp failed for gtk-vnc-plugin.c Steps to reproduce: 1. check gtk-vnc trunk code 2. ./autogen --prefix=/usr --enable-plugin --enable-debug 3. Actual results: build fail with above error message Expected results: build pass Does this happen every time? yes Other information: will offer patch later
Created attachment 124792 [details] [review] patch for bug #564718 This bug is because npupp.h is not sipped since firefox 3.1, the logic are moved into other header files: naapi.h, npfunctions.h, nptypes.h, npruntime.h Also, solaris does not know int16/int32/uint16/uint32, replace them with int16_t/int32_t/uint16_t/uint32_t.
Hi, Halton. Does your code compile against current (3.0) firefox? Please, consider send a message to gtk-vnc mailing list pointing to this bug. Thanks.
(In reply to comment #2) > Hi, Halton. Does your code compile against current (3.0) firefox? No, FF3 does not have npfunctions.h, this patch only works for FF3.1. I'd like to hold this patch until FF3.1 is released. Please get schedule from https://wiki.mozilla.org/Firefox3.1/Schedule > > Please, consider send a message to gtk-vnc mailing list pointing to this bug. Will do after FF3.1 released.
Created attachment 129569 [details] [review] patch to use local copy of npapi.h and npupp.h from FF3.0 I talked with reaplayer and flash developer, they have same issue for this incompatibility between FF3.0 and FF3.1. Their solution is copying nsapi.h and npupp.h from FF3.0 codebase and put them to plugin local repo. This is how this patch comes out.
Ping, any comment with the new patch?
Created attachment 155344 [details] [review] Patch to build with xulrunner 1.9.1 Attached patch is what we're using in Debian since quiet some time.
I have applied Halton's patch from Comment #4. Halton, do you still need your patch from Comment #2 also, or is the second patch sufficient ? Guido, I'm not sure whether you still require your patch from comment #6 in addition, or whether Halton's patch was sufficient.
Created attachment 156729 [details] [review] remove jri in npupp.h No, patch in comment #2 is not needed. Since 3.6, firefox does not ship jri.h, so remove it from npupp.h in advance.
I've applied this additional patch too.
Verified on OpenSolaris.