GNOME Bugzilla – Bug 564587
gtk.Statusbar.remove overrides gtk.HBox.remove
Last modified: 2011-10-25 07:48:55 UTC
Please describe the problem: Widgets can be added/packed into a gtk.Statusbar but not removed again. This is a problem with the API. One solution would be to rename the method of gtk.Statusbar to "remove_message" rather than "remove" (such as is done in gtkmm). Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
I'm not sure if we can really do anything about this in 2.x, because it would then break backward-compatibility in a very bad way. One idea is to hack gtk.Statusbar.remove to invoke gtk.Container.remove if called with only one parameter. But we should certainly add remove_message(). As a workaround you probably can gtk.Container.remove (statusbar, ...), though I didn't try.
This workaround does work. Assuming statusbar is a gtk.Statusbar, and my_box is a gtk.Widget, instead of calling statusbar.remove(my_box) one can call gtk.HBox.remove(statusbar, my_box). Thanks!
Created attachment 133811 [details] [review] proposed patch Add new gtk.Statusbar.remove_message with old semantics. gtk.Statusbar.remove can still be used to remove messages, but there will be a deprecation warning. gtk.Statusbar.remove can now be used to remove child widgets.
Created attachment 133812 [details] [review] proposed patch Add new gtk.Statusbar.remove_message with old semantics. gtk.Statusbar.remove can still be used to remove messages, but there will be a deprecation warning. gtk.Statusbar.remove can now be used to remove child widgets.
Johan, if possible, please review this. I'm not completely sure it is the approach to take, but, on the other hand, I seriously dislike this method hiding stuff, even if widgets are not going to be removed from status bars 99% of the time.
You could just do as you suggested in comment #1 and just leave the API the same but disambiguate the call in gtk.Statusbar.remove() as your new code already does. No need for doc changes or deprecation warnings, etc.
The reason I dislike disambiguation is because the functions do so different things. Maybe still document remove_message() as preferred function, but disambiguate silently, i.e. without deprecation warning?
Paul, I would certainly add a remove_message() and deprecate the old call to remove with a meaningful message as you have already done in the docs and in the defs.
So I applied the patch in its original form, with deprecation warning. Sorry, John ;)
No problem. I'm just part of the peanut gallery. :-)
This is still broken in GTK+ 3. http://developer.gnome.org/gtk3/3.0/GtkStatusbar.html The remove() method of StatusBar has the same name as the remove() method of Container, causing the latter to be overridden in Python.
(In reply to comment #11) > This is still broken in GTK+ 3. > > http://developer.gnome.org/gtk3/3.0/GtkStatusbar.html > > The remove() method of StatusBar has the same name as the remove() method of > Container, causing the latter to be overridden in Python. pygtk does not support gtk3