After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564003 - gvfs Cygwin patches
gvfs Cygwin patches
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: build
1.0.x
Other Cygwin
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2008-12-10 16:03 UTC by Yaakov Selkowitz
Modified: 2009-03-05 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
no-undefined patch (334 bytes, patch)
2008-12-10 16:05 UTC, Yaakov Selkowitz
none Details | Review
struct timeval patch (334 bytes, patch)
2008-12-10 16:10 UTC, Yaakov Selkowitz
committed Details | Review

Description Yaakov Selkowitz 2008-12-10 16:03:11 UTC
I'm attaching two patches for fixing the build of gvfs on Cygwin.
Comment 1 Yaakov Selkowitz 2008-12-10 16:05:04 UTC
Created attachment 124356 [details] [review]
no-undefined patch

This is required to build a shared libgvfscommon on Cygwin.
Comment 2 Yaakov Selkowitz 2008-12-10 16:10:32 UTC
Created attachment 124360 [details] [review]
struct timeval patch

struct timeval is provided by <sys/time.h>.
Comment 3 Alexander Larsson 2009-03-02 11:02:12 UTC
I applied the timeval patch. But why is -no-undefined needed? It should only cause the reporting of undefined symbols, not affect the final result.
Comment 4 Yaakov Selkowitz 2009-03-02 14:03:44 UTC
from libtool:

    case $host in
    *-*-cygwin* | *-*-mingw* | *-*-pw32* | *-*-os2* | *-cegcc*)
      # FIXME: Unfortunately, there are problems with the above when trying
      # to make a dll which has undefined symbols, in which case not
      # even a static library is built.  For now, we need to specify
      # -no-undefined on the libtool link line when we can be certain
      # that all symbols are satisfied, otherwise we get a static library.

Comment 5 Alexander Larsson 2009-03-05 15:46:01 UTC
commited