After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563903 - as-python should check for newer pythons too
as-python should check for newer pythons too
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 668309 686317 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-12-09 20:03 UTC by Olivier Crête
Modified: 2012-11-21 21:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix in git format-patch form (915 bytes, patch)
2009-02-05 14:22 UTC, Olivier Crête
reviewed Details | Review

Description Olivier Crête 2008-12-09 20:03:10 UTC
It should check for newer pythons too.. and I guess we need something to be smart about python 3 too in the near future

--- common/m4/as-python.m4	(revision 22734)
+++ common/m4/as-python.m4	(working copy)
@@ -40,7 +40,8 @@
   dnl in 1.5, and I don't want to maintain that logic.
 
   dnl should we do the version check?
-  PYTHON_CANDIDATES="python python2.2 python2.1 python2.0 python2 \
+  PYTHON_CANDIDATES="python python2.6 python2.5 python 2.4 python 2.3 \
+                     python2.2 python2.1 python2.0 python2 \
                      python1.6 python1.5"
   ifelse([$1],[],
          [AC_PATH_PROG(PYTHON, $PYTHON_CANDIDATES)],
Comment 1 Olivier Crête 2009-02-05 14:22:52 UTC
Created attachment 128006 [details] [review]
fix in git format-patch form

here's an easy to add patch, can we get it merged ?
Comment 2 Olivier Crête 2009-03-17 05:03:54 UTC
Any objection to me committing this ?
Comment 3 Olivier Crête 2009-04-14 16:57:30 UTC
Actually, we should probably just use AM_PYTHON instead..
Comment 4 Sebastian Dröge (slomo) 2011-05-19 17:11:56 UTC
Ok, I agree that AM_PYTHON should be used. Want to fix it? :)
Comment 5 Tim-Philipp Müller 2012-03-03 18:18:39 UTC
This is just for our gtk-doc-plugins.mak right?

If I'm not mistaken, the explicit AS_PYTHON in most of our module configure.ac can be removed, and m4/gst-plugin-docs.m4 can then do whatever it wants to set PYTHON.

We should first find out if it's all python3-safe though.
Comment 6 Tim-Philipp Müller 2012-10-31 17:58:25 UTC
Committed this to common and core now, let's see what it breaks:


commit cb3afe73b85415a15c8d540702f2afc00678c909
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Wed Oct 31 17:48:43 2012 +0000

    gst-plugin-docs.m4: bump python requirement from 2.1 to 2.7

commit f76c9d0bacf3f1c070416b5d8a39b516721c005e
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Wed Oct 31 00:24:14 2012 +0000

    plugin docs: make misc pythons scripts work with python3
    
     - print is a function now
     - foo.has_key(bar) -> bar in foo
     - raise err, text -> raise err(text)
     - uncode strings vs. bytes
    
    https://bugzilla.gnome.org/show_bug.cgi?id=563903

commit cad6cfe02a1a69d691de342b967fb7b6e33db0fb
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Sat Oct 27 15:39:57 2012 +0100

    m4: AG_GST_PLUGIN_DOCS: use AM_PYTHON_PATH instead of our AS_PATH_PYTHON
    
    And make the minimum python version argument optional since it's
    for our own python code in common.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=563903


commit d90d5acdc62ab82620c9b8576b80600b2516944f
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Wed Oct 31 17:37:37 2012 +0000

    configure: let AG_GST_PLUGIN_DOCS check for python
    
    And update common for move from AS_PATH_PYTHON to AM_PATH_PYTHON,
    which as a side-effect should pick up newer python versions as well.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=563903
Comment 7 Tim-Philipp Müller 2012-11-07 23:12:53 UTC
Pushed some more stuff, now also to -base, -good, -ugly and -bad.
Comment 8 Tim-Philipp Müller 2012-11-21 21:17:55 UTC
*** Bug 668309 has been marked as a duplicate of this bug. ***
Comment 9 Tim-Philipp Müller 2012-11-21 21:24:17 UTC
*** Bug 686317 has been marked as a duplicate of this bug. ***