After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563867 - "Open Link in Browser" uses "&" instead of &
"Open Link in Browser" uses "&" instead of &
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.24.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-12-09 15:49 UTC by Felix Riemann
Modified: 2009-02-03 13:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
use present unescaping function for both (3.19 KB, patch)
2009-01-07 18:35 UTC, Felix Riemann
committed Details | Review
updated patch (for trunk) (3.15 KB, patch)
2009-01-12 11:59 UTC, Felix Riemann
committed Details | Review

Description Felix Riemann 2008-12-09 15:49:29 UTC
If you have a mail with contains a link containing more than one query (e.g. http://www.google.de/search?hl=de&q=Evolution ) and do a right click on that link and select "Open Link in Browser" it will send ...&q=... to the browser.

I found some bug reports stating that this was fixed in GtkHTML (which is right as a simple left click works as espected), but it looks like it was forgotten in the right click menu.
Comment 1 Matthew Barnes 2008-12-09 16:36:28 UTC
Do you happen to have the GtkHTML bug number handy?

The "Open Link in Browser" part lives in Evolution, so the same fix probably just needs to be applied there.
Comment 2 Felix Riemann 2008-12-09 16:53:52 UTC
This is the one that resulted in a fix for GtkHTML: bug #485700

But there is also this one which seems to include the unescaping code into Evo already (for Copy Link): bug #506948
Comment 3 Felix Riemann 2009-01-07 18:35:30 UTC
Created attachment 125953 [details] [review]
use present unescaping function for both

This makes the already present unescaping function available to both functions.

em-utils looked like the right place for the utility function to me, not fully sure though (evo is quite big).
Comment 4 Srinivasa Ragavan 2009-01-12 04:14:36 UTC
Commit to stable/trunk
Comment 5 Suman Manjunath 2009-01-12 04:54:50 UTC
Sorry, there have been some changes in the source code and your patch probably needs to be re-based/modified. Marking as such. 
Comment 6 Felix Riemann 2009-01-12 11:59:11 UTC
Created attachment 126263 [details] [review]
updated patch (for trunk)

Okay, this should apply to trunk again. The only thing that needed to be changed, was the em-popup.c chunk.

Attachment 125953 [details] theoretically still applies to the 2.24 series. But I don't know if it's still needed as it looks like I missed the 2.24.3 release.
Comment 7 Suman Manjunath 2009-01-13 03:44:05 UTC
(In reply to comment #3)
> Created an attachment (id=125953) [edit]
> use present unescaping function for both

Patch committed to stable (gnome-2-24) branch as r37062
http://svn.gnome.org/viewvc/evolution?view=revision&revision=37062

(In reply to comment #6)
> Created an attachment (id=126263) [edit]
> updated patch (for trunk)

Patch committed to SVN trunk as r37063
http://svn.gnome.org/viewvc/evolution?view=revision&revision=37063

> Attachment 125953 [details] [edit] theoretically still applies to the 2.24 series. But I don't
> know if it's still needed as it looks like I missed the 2.24.3 release.

I think a 2.24.4 is planned. Your patch will make it to that release :-)
Comment 8 Felix Riemann 2009-02-03 13:45:11 UTC
Just got Evo 2.24.4 through my package manager. I guess this can be closed then.