After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563702 - Should check libtasn1 through the libtasn1.pc file with pkg-config
Should check libtasn1 through the libtasn1.pc file with pkg-config
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
2.25.x
Other All
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-12-08 15:26 UTC by Jeff Cai
Modified: 2009-09-13 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use pkg-config to get building flags (640 bytes, patch)
2008-12-08 15:29 UTC, Jeff Cai 		committed Details | Review

Description Jeff Cai 2008-12-08 15:26:59 UTC 
Since libtasn1 1.6 has removed libtasn1.m4, gnome-keyring should use pkg-config to get the building flags.
Comment 1 Jeff Cai 2008-12-08 15:29:27 UTC 
Created attachment 124178 [details] [review]
Use pkg-config to get building flags
Comment 2 Stef Walter 2008-12-11 20:16:30 UTC 
Thanks. Committed.

Do you know off hand which was the earliest libtasn1 version that included the pkg-config file? We should probably update the minimum required version gnome-keyring depends on.
Comment 3 Daniel Black 2009-02-08 20:12:56 UTC 
dup of bug 560869
Comment 4 Adrian Bunk 2009-08-25 11:11:49 UTC 
(In reply to comment #2)
> 
> Do you know off hand which was the earliest libtasn1 version that included the
> pkg-config file? We should probably update the minimum required version
> gnome-keyring depends on.

It's included since libtasn1 0.2.14, so no need to update anything.

BTW:
Was it intended to no longer use GKR_LIBTASN1_VERSION?
Comment 5 Stef Walter 2009-08-29 16:15:44 UTC 
Yes, it seems like nothing in the code uses GKR_LIBTASN1_VERSION any more.
Comment 6 Adrian Bunk 2009-08-29 16:26:42 UTC 
(In reply to comment #5)
> Yes, it seems like nothing in the code uses GKR_LIBTASN1_VERSION any more.

What I was wondering about is, why the patch from this bug replaced the GKR_LIBTASN1_VERSION usage with 1.0 .

Was this dependency increase intended?
Comment 7 Stef Walter 2009-09-13 16:00:02 UTC 
Thanks for catching that. Reverted that part of the change.