After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563549 - Sizing problems reappeared with a recent commit
Sizing problems reappeared with a recent commit
Status: RESOLVED DUPLICATE of bug 549403
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2008-12-07 10:52 UTC by Milan Bouchet-Valat
Modified: 2008-12-22 21:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot showing invalid default position of the dialog (181.51 KB, image/png)
2008-12-07 11:00 UTC, Milan Bouchet-Valat
Details
Screenshot with too small dialog (22.54 KB, image/png)
2008-12-07 11:05 UTC, Milan Bouchet-Valat
Details

Description Milan Bouchet-Valat 2008-12-07 10:52:19 UTC
Recently users have been complaining again (see [1]) about too small file chooser dialogs, a bug that had just been fixed in GTK 2.12.

Looking in the code for changes, I found these commits, which apply to gtkfilechooserdialog.c. They were designed to solve bug 543308, which was in turn triggered by another commit intending to fix another bug. So maybe we should be careful here! ;-)
As these changes are the only ones that occurred since 2.12, I think they're the cause of the problem:

------------------------------------------------------------------------
r21163 | federico | 2008-08-20 03:11:20 +0200 (mer 20 aoû 2008) | 3
lines

[PATCH 2/7] bgo543308 - Remove obsolete sizing code in
GtkFileChooserDialog

------------------------------------------------------------------------
r21162 | federico | 2008-08-20 03:10:59 +0200 (mer 20 aoû 2008) | 3
lines

[PATCH 1/7] bgo543308 - Let the file chooser widget be in charge of its
default size; don't force it from the dialog


In 2.14, two issues have appeared:
- the file chooser dialog is resized *after* being shown, prompting the
window manager not to center the window on the screen (no speaking about the bad effect of the dialog moving on the screen)
- some users report problems about the dialog being much too small (see
screenshots on the Ubuntu bug report)

About the latter, I'm not able to reproduce it and it seems to be quite random, with some users getting it almost everytime, others one in a while (I saw it once, and never since then). We may still assume it is triggered by the first issue, for example if the window manager is not resizing the dialog as it wants to change size at the moment it is being displayed (this happens under Metacity and Compiz, but with changing frequencies, according to reporters).

Quite strange anyway, but the current resizing design is bad. The window should be shown after being resized. If you give me some hints I can investigate the issue.


1: https://bugs.launchpad.net/bugs/75324
Comment 1 Milan Bouchet-Valat 2008-12-07 11:00:05 UTC
Created attachment 124085 [details]
Screenshot showing invalid default position of the dialog
Comment 2 Milan Bouchet-Valat 2008-12-07 11:05:56 UTC
Created attachment 124087 [details]
Screenshot with too small dialog
Comment 3 Milan Bouchet-Valat 2008-12-22 21:52:51 UTC

*** This bug has been marked as a duplicate of 549403 ***