GNOME Bugzilla – Bug 563403
Insufficient options for importing folder hierarchy in preferences
Last modified: 2009-11-11 00:50:46 UTC
When selecting the Folder Hierarchy as anyone which includes the Artist, it selects the Track artist, and not the Album Artist. Then, in the case of album compilations, it creates one folder per track artist breaking the compilation as it in the filesystem. In that case, it would be better to look first if the track has an Album Artist field set, and then use it for the Folder Hierarchy, and if not, then use the track artist field. Other possible solution is to add to the options the same options that has Artist, but also with "Album Artist" in the url.
Created attachment 124264 [details] [review] adds formating options to Folder Hierarchy This patch contains: *) a %album_artist% field that defaults to the %artist% if track is not part of a compilation. (This sorts compilations with different track artists into a single folder.) *) a %year_string% field that is only non-empty if track is not part of a compilation. (This sorts compilations with different years in the tracks into a single folder.) *) a %disc_string% field that is only non-empty if there is more than one disc to an album. (This sorts different discs into different folders if there is more than one disc. This is necessary for stupid players that don't honour the disc number.) Grettings, Andi
Thanks for the patch ! This patch provides a superset of the features from the one in bug #560583 (disc number pattern). A few comments : 1. I don't really like the "*_string" names. Maybe %album_year% and %disc% or %disc_number% would be better ? 2. The "year" token probably shouldn't include the parenthesis. You can add them in the pattern anyway : "%album% - %album_artist% (%album_year%) %path_sep%%disc_string%" 3. The "disc" token shouldn't contain "of", it's not flexible and not localizable. Creating 2 separate tokens %disc_number% and %disc_count% would be more flexible, in particular for those who only want the disc number. As above, you can achieve the same result with a pattern : "%disc_number% of %disc_count%"
*** Bug 564518 has been marked as a duplicate of this bug. ***
*** Bug 560583 has been marked as a duplicate of this bug. ***
On bug #560583 Shaun has a nifty patch (http://bugzilla.gnome.org/attachment.cgi?id=124230) for including the disc# in the filename, iff there is more than one disc for the album. This is a good idea we should include. I think we should have a "Custom..." option in our current dropdown that opens a new dialog for editing in some fashion a custom pattern.
(In reply to comment #2) > A few comments : > 2. The "year" token probably shouldn't include the parenthesis. You can add > them in the pattern anyway : > "%album% - %album_artist% (%album_year%) %path_sep%%disc_string%" I wrote the %year_string% in this way because for compilations (where %album_year% would be empty) the string " ()" would be appended to the album name when putting the parenthesis in the format string. In my patch the year disappears completely for compilations. > 3. The "disc" token shouldn't contain "of", it's not flexible and not > localizable. Creating 2 separate tokens %disc_number% and %disc_count% would be > more flexible, in particular for those who only want the disc number. > As above, you can achieve the same result with a pattern : > "%disc_number% of %disc_count%" Same problem here, your solution would give "Disc 1 of 1" folders in _every_ album folder. So its a context dependent string that is completely empty in case there is only one disc (or no disc info) and creates new folders "Disc 1 of x", "Disc 2 of x", ... if there are at least 2 discs. As for the "of" and "Disc", yes, they should be removed leaving only something like "x-y" or the like. > 1. I don't really like the "*_string" names. Maybe %album_year% and %disc% or > %disc_number% would be better ? And the above points are the reason I named them *_strings since they are an aggregation of information (from numbers) that have also some context dependent formatting. (In reply to comment #5) >I think we should have a "Custom..." option in our current dropdown that > opens a new dialog for editing in some fashion a custom pattern. Yes, this would be great. My codings skills didn't permit me to add GUI code :-)
I wonder why this patch isn't added in the mainstream yet.
Andreas, thanks for your patch and sorry we were slow to review it. Most of the points it addresses are already in git master, see commit 369a998. I'm closing the bug as a duplicate of bug 489861 which tracks the remaining issues related to the library organisation. If I missed anything, please comment in that bug. *** This bug has been marked as a duplicate of bug 489861 ***