After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563303 - Expose lame presets in encoder profile
Expose lame presets in encoder profile
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: Normal enhancement
: 1.6
Assigned To: Aaron Bockover
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-05 01:53 UTC by Christopher Halse Rogers
Modified: 2009-06-04 20:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch against trunk (2.83 KB, patch)
2008-12-05 01:54 UTC, Christopher Halse Rogers
needs-work Details | Review
Updated patch. (3.31 KB, patch)
2009-01-14 20:24 UTC, Christopher Halse Rogers
needs-work Details | Review
Make the enables="" disables="" order consistent. (842 bytes, patch)
2009-01-14 20:26 UTC, Christopher Halse Rogers
needs-work Details | Review
Updated patch, mk2. (2.94 KB, patch)
2009-01-16 04:27 UTC, Christopher Halse Rogers
committed Details | Review

Description Christopher Halse Rogers 2008-12-05 01:53:40 UTC
Expose the LAME presets in the encoder profile.  These are interesting because each preset is a highly tuned collection of encoder settings for simultaneously maximising audio quality and minimising bitrate.

I've used the names of the presets as defined by LAME; they could possibly be better labelled.  "Medium" usually corresponds to ~160kbit/s, "Standard" to ~192kbit/s and is about the point at which compression artefacts are inaudiable.  Suggestions for better labels would be welcome.
Comment 1 Christopher Halse Rogers 2008-12-05 01:54:11 UTC
Created attachment 123973 [details] [review]
Patch against trunk
Comment 2 Gabriel Burt 2009-01-14 01:40:07 UTC
Hey Christopher, thanks for the patch.  Should the "LAME Preset" label/dropdown be shown when Variable and Average Bitrate are selected?
Comment 3 Christopher Halse Rogers 2009-01-14 01:54:56 UTC
No.  The LAME presets tweak _all_ the encoding knobs.  They set the VBR parameters themselves, among other settings. I'm not entirely sure what settings would win if you set both preset and VBR/ABR parameters, but you probably don't want to do that anyway.
Comment 4 Gabriel Burt 2009-01-14 15:54:41 UTC
OK, I only ask b/c with your patch that's what happens.  :)
Comment 5 Christopher Halse Rogers 2009-01-14 20:24:44 UTC
Created attachment 126457 [details] [review]
Updated patch.

Curses!  I thought I'd tested that?

Oh.  It's because the enables and disables attributes are switched in the first entry.
Comment 6 Christopher Halse Rogers 2009-01-14 20:26:09 UTC
Created attachment 126458 [details] [review]
Make the enables="" disables="" order consistent.

While I'm at it, here's a patch to make the ordering of enables, disables consistent in that section, so people don't make the same mistake again :).
Comment 7 Gabriel Burt 2009-01-16 03:16:37 UTC
You've got the shamrock fix in your first patch.

The <value value="medium">Medium</value> values should be marked as translatable.

Go ahead and combine the two patches into one.  Thanks!
Comment 8 Christopher Halse Rogers 2009-01-16 04:27:13 UTC
Created attachment 126553 [details] [review]
Updated patch, mk2.
Comment 9 Gabriel Burt 2009-01-23 00:51:20 UTC
This looks solid to me, I'll assign to Aaron for final approval.
Comment 10 Gabriel Burt 2009-06-04 20:06:06 UTC
Thanks Christopher (and sorry for the long delay), committed/pushed to git master.