GNOME Bugzilla – Bug 563303
Expose lame presets in encoder profile
Last modified: 2009-06-04 20:06:06 UTC
Expose the LAME presets in the encoder profile. These are interesting because each preset is a highly tuned collection of encoder settings for simultaneously maximising audio quality and minimising bitrate. I've used the names of the presets as defined by LAME; they could possibly be better labelled. "Medium" usually corresponds to ~160kbit/s, "Standard" to ~192kbit/s and is about the point at which compression artefacts are inaudiable. Suggestions for better labels would be welcome.
Created attachment 123973 [details] [review] Patch against trunk
Hey Christopher, thanks for the patch. Should the "LAME Preset" label/dropdown be shown when Variable and Average Bitrate are selected?
No. The LAME presets tweak _all_ the encoding knobs. They set the VBR parameters themselves, among other settings. I'm not entirely sure what settings would win if you set both preset and VBR/ABR parameters, but you probably don't want to do that anyway.
OK, I only ask b/c with your patch that's what happens. :)
Created attachment 126457 [details] [review] Updated patch. Curses! I thought I'd tested that? Oh. It's because the enables and disables attributes are switched in the first entry.
Created attachment 126458 [details] [review] Make the enables="" disables="" order consistent. While I'm at it, here's a patch to make the ordering of enables, disables consistent in that section, so people don't make the same mistake again :).
You've got the shamrock fix in your first patch. The <value value="medium">Medium</value> values should be marked as translatable. Go ahead and combine the two patches into one. Thanks!
Created attachment 126553 [details] [review] Updated patch, mk2.
This looks solid to me, I'll assign to Aaron for final approval.
Thanks Christopher (and sorry for the long delay), committed/pushed to git master.