After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563302 - soup_form_decode() returns incorrect results when string contains URL encoded characters
soup_form_decode() returns incorrect results when string contains URL encoded...
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2008-12-05 01:44 UTC by Evan Nemerson
Modified: 2008-12-05 03:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The least invasive fix I could think of. (456 bytes, patch)
2008-12-05 01:45 UTC, Evan Nemerson
none Details | Review

Description Evan Nemerson 2008-12-05 01:44:11 UTC
The location of the parameter value is set prior to decoding URL encoded characters. If a key contains a URL encoded value, the location changes, the key contains extra characters, and the beginning of the value is truncated.
Comment 1 Evan Nemerson 2008-12-05 01:45:22 UTC
Created attachment 123972 [details] [review]
The least invasive fix I could think of.
Comment 2 Dan Winship 2008-12-05 03:58:56 UTC
That patch won't quite work because it would do the wrong thing if the parameter name had a %-encoded "=" in it. But I've fixed it now in svn, and added a regression test for that case. The fix will eventually make it into 2.24.3 and 2.25.3. Thanks for the bug report.