GNOME Bugzilla – Bug 563251
oggmux should have option to create Ogg Skeleton stream
Last modified: 2011-08-25 06:33:31 UTC
gstreamer right now provides no way to create ogg files with skeleton stream. according to http://wiki.xiph.org/index.php/MIME_Types_and_File_Extensions ogg streams with video should contain an ogg skeleton stream. more information on ogg skeleton: http://wiki.xiph.org/OggSkeleton
OggSkeleton 4 (http://wiki.xiph.org/Ogg_Skeleton_4) now also includes an index that makes seeking in http resources a lot faster. This is used in Firefox 4. Would be nice to be able to create files with index with gstreamer without requiring and external tool to add the index.
Created attachment 194104 [details] [review] oggmux: add skeleton write support Version written is 3.0 Base times are left empty for now. Content-Type should be the MIME type of the stream. It is set to the GStreamer media type for now, which is probably the same for the streams oggmux supports.
Created attachment 194143 [details] [review] oggmux: generate message headers from received tags Some message headers can be deduced from tags (eg, "Language").
Review of attachment 194104 [details] [review]: ::: ext/ogg/gstoggmux.c @@ +1170,3 @@ + + fishead = gst_buffer_new_and_alloc (64); + gst_byte_writer_init_with_buffer (&bw, fishead, TRUE); initialized should be FALSE, not TRUE. The buffer data is not initialized
Review of attachment 194143 [details] [review]: ::: ext/ogg/gstoggmux.c @@ +370,3 @@ + if (tags) + tags = gst_tag_list_copy (tags); + ogg_pad->tags = tags; You should merge the two taglists instead of replacing them
Created attachment 194461 [details] [review] Updated to apply on latest git. oggmux: add skeleton write support Version written is 3.0 Base times are left empty for now. Content-Type should be the MIME type of the stream. It is set to the GStreamer media type for now, which is probably the same for the streams oggmux supports.
commit 2301f1806fcef40c502560304d2f17641a2dea53 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Wed Aug 17 17:09:44 2011 +0100 oggmux: add skeleton write support Version written is 3.0 Base times are left empty for now. Content-Type should be the MIME type of the stream. It is set to the GStreamer media type for now, which is probably the same for the streams oggmux supports. https://bugzilla.gnome.org/show_bug.cgi?id=563251
Created attachment 194563 [details] [review] oggmux: set initialized to FALSE on the bit writer, merge tags Review comments from previous patches.
Sorry, I'd missed those comments and only saw them when looking for the bug, hadn't even realized this had been pushed yet. Comments addressed in new patch.
Created attachment 194640 [details] [review] oggmux: fix leaks in skeleton writing
Also reopening as only one of the two original patches was pushed.
I've only pushed the first patch previously, now all are pushed. Thanks for noticing commit fd218c4ec2fb6b231257ea82b6bb23b9b776d505 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Wed Aug 24 17:39:11 2011 +0100 oggmux: fix leaks in skeleton writing https://bugzilla.gnome.org/show_bug.cgi?id=563251 commit 29038283bc3d931a16139eb1a2e4e0db6c8c9f2a Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Thu Aug 18 16:36:23 2011 +0100 oggmux: generate message headers from received tags Some message headers can be deduced from tags (eg, "Language"). https://bugzilla.gnome.org/show_bug.cgi?id=563251