After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563251 - oggmux should have option to create Ogg Skeleton stream
oggmux should have option to create Ogg Skeleton stream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-04 17:23 UTC by j^
Modified: 2011-08-25 06:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
oggmux: add skeleton write support (9.83 KB, patch)
2011-08-18 08:32 UTC, Vincent Penquerc'h
needs-work Details | Review
oggmux: generate message headers from received tags (5.06 KB, patch)
2011-08-18 15:42 UTC, Vincent Penquerc'h
committed Details | Review
Updated to apply on latest git. (9.81 KB, patch)
2011-08-23 10:32 UTC, Vincent Penquerc'h
committed Details | Review
oggmux: set initialized to FALSE on the bit writer, merge tags (1.58 KB, patch)
2011-08-24 10:11 UTC, Vincent Penquerc'h
committed Details | Review
oggmux: fix leaks in skeleton writing (942 bytes, patch)
2011-08-24 16:41 UTC, Vincent Penquerc'h
committed Details | Review

Description j^ 2008-12-04 17:23:42 UTC
gstreamer right now provides no way to create ogg files with skeleton stream.

according to http://wiki.xiph.org/index.php/MIME_Types_and_File_Extensions
ogg streams with video should contain an ogg skeleton stream.

more information on ogg skeleton: http://wiki.xiph.org/OggSkeleton
Comment 1 j^ 2011-03-17 17:40:01 UTC
OggSkeleton 4 (http://wiki.xiph.org/Ogg_Skeleton_4) now also includes an index that makes seeking in http resources a lot faster. This is used in Firefox 4. Would be nice to be able to create files with index with gstreamer without requiring and external tool to add the index.
Comment 2 Vincent Penquerc'h 2011-08-18 08:32:54 UTC
Created attachment 194104 [details] [review]
oggmux: add skeleton write support

Version written is 3.0

Base times are left empty for now.

Content-Type should be the MIME type of the stream. It is set to
the GStreamer media type for now, which is probably the same for
the streams oggmux supports.
Comment 3 Vincent Penquerc'h 2011-08-18 15:42:19 UTC
Created attachment 194143 [details] [review]
oggmux: generate message headers from received tags

Some message headers can be deduced from tags (eg, "Language").
Comment 4 Sebastian Dröge (slomo) 2011-08-19 07:44:11 UTC
Review of attachment 194104 [details] [review]:

::: ext/ogg/gstoggmux.c
@@ +1170,3 @@
+
+  fishead = gst_buffer_new_and_alloc (64);
+  gst_byte_writer_init_with_buffer (&bw, fishead, TRUE);

initialized should be FALSE, not TRUE. The buffer data is not initialized
Comment 5 Sebastian Dröge (slomo) 2011-08-19 07:45:24 UTC
Review of attachment 194143 [details] [review]:

::: ext/ogg/gstoggmux.c
@@ +370,3 @@
+      if (tags)
+        tags = gst_tag_list_copy (tags);
+      ogg_pad->tags = tags;

You should merge the two taglists instead of replacing them
Comment 6 Vincent Penquerc'h 2011-08-23 10:32:54 UTC
Created attachment 194461 [details] [review]
Updated to apply on latest git.

oggmux: add skeleton write support

Version written is 3.0

Base times are left empty for now.

Content-Type should be the MIME type of the stream. It is set to
the GStreamer media type for now, which is probably the same for
the streams oggmux supports.
Comment 7 Sebastian Dröge (slomo) 2011-08-24 06:22:46 UTC
commit 2301f1806fcef40c502560304d2f17641a2dea53
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Wed Aug 17 17:09:44 2011 +0100

    oggmux: add skeleton write support
    
    Version written is 3.0
    
    Base times are left empty for now.
    
    Content-Type should be the MIME type of the stream. It is set to
    the GStreamer media type for now, which is probably the same for
    the streams oggmux supports.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=563251
Comment 8 Vincent Penquerc'h 2011-08-24 10:11:20 UTC
Created attachment 194563 [details] [review]
oggmux: set initialized to FALSE on the bit writer, merge tags

Review comments from previous patches.
Comment 9 Vincent Penquerc'h 2011-08-24 10:12:25 UTC
Sorry, I'd missed those comments and only saw them when looking for the bug, hadn't even realized this had been pushed yet.
Comments addressed in new patch.
Comment 10 Vincent Penquerc'h 2011-08-24 16:41:40 UTC
Created attachment 194640 [details] [review]
oggmux: fix leaks in skeleton writing
Comment 11 Vincent Penquerc'h 2011-08-24 16:42:33 UTC
Also reopening as only one of the two original patches was pushed.
Comment 12 Sebastian Dröge (slomo) 2011-08-25 06:33:31 UTC
I've only pushed the first patch previously, now all are pushed. Thanks for noticing

commit fd218c4ec2fb6b231257ea82b6bb23b9b776d505
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Wed Aug 24 17:39:11 2011 +0100

    oggmux: fix leaks in skeleton writing
    
    https://bugzilla.gnome.org/show_bug.cgi?id=563251

commit 29038283bc3d931a16139eb1a2e4e0db6c8c9f2a
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Thu Aug 18 16:36:23 2011 +0100

    oggmux: generate message headers from received tags
    
    Some message headers can be deduced from tags (eg, "Language").
    
    https://bugzilla.gnome.org/show_bug.cgi?id=563251