Bug 562939 - Pointers initialized to garbage instead of values set by XGetWindowProperty
Pointers initialized to garbage instead of values set by XGetWindowProperty
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.25.x
Other All
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2008-12-02 04:50 UTC by Matt Kraai
Modified: 2008-12-02 08:16 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.31 KB, patch)
2008-12-02 04:52 UTC, Matt Kraai 		committed Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Matt Kraai 2008-12-02 04:50:57 UTC 
Please describe the problem:
The fixes for -Wall made to src/core/iconcache.c in revision 4045 initialize the non-guchar pointers to garbage values instead of setting them to the values set by XGetWindowProperty.  For example, in read_rgb_icon, data_as_long is set to whatever value happens to initially be in data, rather than what data is set to by XGetWindowProperty.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
I'll attach a patch that fixes this issue shortly.
Comment 1 Matt Kraai 2008-12-02 04:52:33 UTC 
Created attachment 123774 [details] [review]
Patch
Comment 2 Thomas Thurman 2008-12-02 08:16:10 UTC 
I can't believe I wrote that :/  Committed with thanks.
Note You need to log in before you can comment on or make changes to this bug.