GNOME Bugzilla – Bug 562892
happy valgrind
Last modified: 2008-12-01 18:49:46 UTC
Valgrind has been complaining on x86_64 for a long time about the get_obj_key function, and since it was extremely noisy for me and obscured other (more important) errors I decided to track it down. Basically, the previous logic was too simple to work. We were walking off the end of d.bytes by iterating up to i < sizeof(void*)*2, where d.bytes is just 0 < sizeof(void*). Why it wasn't complaining on x86 probably comes down to something else living on the stack there that was assigned. To be correct we separate iteration for each repetition of the address from iteration over the components of d.
Created attachment 123747 [details] [review] fix iteration
Created attachment 123748 [details] [review] more commented, cleaner No functional changes here, just makes the i/j ordering more traditional, and adds a comment.
Created attachment 123751 [details] [review] simpler patch
Committed r124 M gi/object.c r124 = 1a8e633fa4b919faec86733e23332ab55b425cb9 (git-svn)