After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562611 - [REGRESSION] Can't save web pages on local files
[REGRESSION] Can't save web pages on local files
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
git master
Other Linux
: Normal normal
: ---
Assigned To: Gustavo Noronha (kov)
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-28 20:35 UTC by Luca Ferretti
Modified: 2009-09-17 10:06 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
firs pass at implementing this (10.60 KB, patch)
2009-08-20 18:04 UTC, Gustavo Noronha (kov)
none Details | Review

Description Luca Ferretti 2008-11-28 20:35:51 UTC
File -> Save As.. action do nothing in WebKit backend

# Steps to reproduce
 * Open a web page
 * Choose File -> Save as..

# Current result
 Nothing

# Expected result
 Open filechooser in save mode, at least :)
Comment 1 Gustavo Noronha (kov) 2009-08-20 18:04:10 UTC
Created attachment 141268 [details] [review]
firs pass at implementing this

This is a first pass. The DataSource API is bound to change at least slightly, so this patch will need to be updated when that happens.

TODO:

  * Suggest a filename, based on the view title
  * Edit the saved HTML/js/css files to point to the local CSS/image files instead(?)
Comment 2 Gustavo Noronha (kov) 2009-09-15 02:06:44 UTC
This is pushed to master, should be in 2.28.
Comment 3 Yavor Doganov 2009-09-16 12:55:44 UTC
Hmm, this relies on webkit_web_data_source_get_subresources which is apparently a pretty new function not in WebKit 1.1.14.  As a result, Ephy fails to build.
Comment 4 Gustavo Noronha (kov) 2009-09-16 13:08:43 UTC
Hey Yavor. Yes, Epiphany currently depends on WebKitGTK+ from trunk. It will depend on 1.1.15 as soon as it's released.
Comment 5 Yavor Doganov 2009-09-16 13:14:37 UTC
Thanks very much for the info.  I'd appreciate if someone updates the jhbuild modulesets as soon as this happens, as we poor translators need to test both epiphany and epiphany-extensions.
Comment 6 Luca Ferretti 2009-09-17 10:06:58 UTC
(In reply to comment #5)
> Thanks very much for the info.  I'd appreciate if someone updates the jhbuild
> modulesets as soon as this happens, as we poor translators need to test both
> epiphany and epiphany-extensions.

Meanwhile you could try to pick up webkit source from here http://nightly.webkit.org/

A simple `jhbuild run ./configure --prefix=XXXX && jhbuild run make && jhbuild run make install` should be enough