Please describe the problem:
Instead of just one profile there are many profiles stored as e.g. profile-901-47533-charging.csv. The 2nd number varies between approx. 47500 and 55000.
Therefore the profile is not correct and statistics are drawn around 0%.


 

Steps to reproduce:
everytime I restart my system a new file is created.

Actual results:


Expected results:
Just one profile should be stored.

Does this happen every time?
yes

Other information:
I've found in source code, that the hal key "battery.charge_level.design" is used to create the file id. A better key would be imho "battery.reporting.design", which doesn't change on my system.

hal: 0.5.11
distri: ubuntu 0.8.10 (eeepc)
gpm: 2.24.0

I've patched and recompiled successfully as follows:

--- gnome-power-manager-2.24.0/src/gpm-cell.c	2008-09-04 12:05:15.000000000 +0200
+++ gnome-power-manager-2.24.0-jb1/src/gpm-cell.c	2008-11-28 13:48:51.000000000 +0100
@@ -103,7 +103,10 @@
 		return FALSE;
 	}
 
-	hal_gdevice_get_uint (device, "battery.charge_level.design",
+	hal_gdevice_get_uint (device, "battery.reporting.design",
+				 &unit->reporting_design, NULL);
+
+	hal_gdevice_get_uint (device, "battery.charge_level.design", 
 				 &unit->charge_design, NULL);
 	hal_gdevice_get_uint (device, "battery.charge_level.last_full",
 				 &unit->charge_last_full, NULL);
@@ -139,13 +142,7 @@
 		if (exists == FALSE && (unit->is_discharging || unit->is_charging == TRUE)) {
 			egg_warning ("could not read your battery's charge rate");
 		}
-		/* sanity check to less than 100W */
-		if (unit->rate > 100*1000) {
-			egg_warning ("sanity checking rate from %i to 0", unit->rate);
-			unit->rate = 0;
-		}
-		/* The ACPI spec only allows this for primary cells, but in the real
-		   world we also see it for rechargeables. Sigh */
+	
 		if (unit->rate == 0) {
 			guint raw_last_charge;
 			hal_gdevice_get_uint (device, "battery.reporting.last_full",
@@ -472,19 +469,20 @@
 {
 	GString *string;
 	gchar *id = NULL;
-
+	
 	g_return_val_if_fail (cell != NULL, NULL);
 	g_return_val_if_fail (GPM_IS_CELL (cell), NULL);
 
 	string = g_string_new ("");
-
+	
+	
 	/* in an ideal world, model-capacity-serial */
 	if (cell->priv->model != NULL && strlen (cell->priv->model) > 2) {
 		g_string_append (string, cell->priv->model);
 		g_string_append_c (string, '-');
 	}
-	if (cell->priv->unit.charge_design > 0) {
-		g_string_append_printf (string, "%i", cell->priv->unit.charge_design);
+	if (cell->priv->unit.reporting_design > 0) {
+		g_string_append_printf (string, "%i", cell->priv->unit.reporting_design);
 		g_string_append_c (string, '-');
 	}
 	if (cell->priv->serial != NULL && strlen (cell->priv->serial) > 2) {


--- gnome-power-manager-2.24.0/src/gpm-cell-unit.h	2008-09-04 12:05:15.000000000 +0200
+++ gnome-power-manager-2.24.0-jb1/src/gpm-cell-unit.h	2008-11-28 13:43:44.000000000 +0100
@@ -44,6 +44,7 @@
 typedef struct {
 	GpmCellUnitKind	 kind;
 	GpmCellUnitMeasure measure;
+	guint		 reporting_design;
 	guint		 charge_design;
 	guint		 charge_last_full;
 	guint		 charge_current;