Created attachment 123585 [details] [review]
patch for this bug

ping

Unfortunately this bug is already obsolete. The patches from 562333 already cover this (the last of them was fixed up last night). Sorry for not spotting this sooner.

*** This bug has been marked as a duplicate of 562333 ***

Slight lie there, a couple of changes weren't picked up by the 562333 patches (they were aimed at libgnome removal, not deprecation - they aren't quite the same things). I've applied them now.

Grep still shows the following deprecated gtk symbols in gnome-applets:

gnome-applets/mini-commander/src/command_line.c:315:     gtk_window_set_policy(GTK_WINDOW(window), 0, 0, 1);
gnome-applets/mini-commander/src/command_line.c:320:			      GTK_SIGNAL_FUNC(history_popup_clicked_cb),
gnome-applets/mini-commander/src/command_line.c:326:     gtk_widget_set_usize(GTK_WIDGET(window), 200, 350);
gnome-applets/mini-commander/src/command_line.c:343:			GTK_SIGNAL_FUNC(history_popup_clicked_inside_cb),
gnome-applets/mini-commander/src/command_line.c:510:    mc->entry = gtk_entry_new_with_max_length (MC_MAX_COMMAND_LENGTH); 
gnome-applets/gswitchit/gswitchit-applet.c:248:	    GTK_BUILDER (gtk_object_get_data
gnome-applets/gswitchit/gswitchit-applet.c:367:	gtk_object_set_data (GTK_OBJECT (dialog), "builderData", builder);
gnome-applets/gswitchit/gswitchit-applet.c:389:	gtk_object_set_data (GTK_OBJECT (dialog), "kbdraw", kbdraw);
gnome-applets/gswitchit/gswitchit-applet.c:668:	gtk_object_set_data (GTK_OBJECT (sia->applet), "sia", sia);
gnome-applets/geyes/geyes.c:43:        gtk_rc_style_unref (rc_style);
gnome-applets/geyes/geyes.c:302:	gtk_timeout_remove (eyes_applet->timeout_id);
gnome-applets/geyes/geyes.c:393:        eyes_applet->timeout_id = gtk_timeout_add (
gnome-applets/battstat/battstat_applet.c:1563:  gtk_widget_ref( battstat->status );
gnome-applets/battstat/battstat_applet.c:1564:  gtk_widget_ref( battstat->percent );
gnome-applets/battstat/battstat_applet.c:1565:  gtk_widget_ref( battstat->battery );
gnome-applets/battstat/battstat_applet.c:1566:  gtk_object_sink( GTK_OBJECT( battstat->status ) );
gnome-applets/battstat/battstat_applet.c:1567:  gtk_object_sink( GTK_OBJECT( battstat->percent ) );
gnome-applets/battstat/battstat_applet.c:1568:  gtk_object_sink( GTK_OBJECT( battstat->battery ) );
gnome-applets/battstat/power-management.c:122:  gtk_box_pack_start_defaults( box, gtk_label_new( "percent" ) );
gnome-applets/battstat/power-management.c:127:  gtk_box_pack_start_defaults( box, w );
gnome-applets/battstat/power-management.c:129:  gtk_box_pack_start_defaults( box, gtk_label_new( "minutes" ) );
gnome-applets/battstat/power-management.c:134:  gtk_box_pack_start_defaults( box, w );
gnome-applets/battstat/power-management.c:141:  gtk_box_pack_start_defaults( box, w );
gnome-applets/battstat/power-management.c:146:  gtk_box_pack_start_defaults( box, w );
gnome-applets/battstat/power-management.c:152:  gtk_box_pack_start_defaults( box, w );
gnome-applets/gweather/gweather-applet.c:282:       gtk_timeout_remove(gw_applet->timeout_tag);
gnome-applets/gweather/gweather-applet.c:287:       gtk_timeout_remove(gw_applet->suncalc_timeout_tag);
gnome-applets/gweather/gweather-applet.c:397:        gtk_timeout_remove(gw_applet->timeout_tag);
gnome-applets/gweather/gweather-applet.c:401:		gtk_timeout_add (
gnome-applets/gweather/gweather-applet.c:408:                        gtk_timeout_add (nxtSunEvent * 1000,
gnome-applets/gweather/gweather-pref.c:343:        gtk_timeout_remove(gw_applet->timeout_tag);
gnome-applets/gweather/gweather-pref.c:345:        gtk_timeout_remove(gw_applet->suncalc_timeout_tag);
gnome-applets/gweather/gweather-pref.c:347:        gw_applet->timeout_tag = gtk_timeout_add (
gnome-applets/gweather/gweather-pref.c:352:	    gw_applet->suncalc_timeout_tag = gtk_timeout_add (
gnome-applets/gweather/gweather-pref.c:548:        gtk_timeout_remove(gw_applet->timeout_tag);
gnome-applets/gweather/gweather-pref.c:551:        	gtk_timeout_add (gw_applet->gweather_pref.update_interval * 1000,
gnome-applets/gweather/gweather-dialog.c:554:      gtk_widget_set_usize(radar_link_btn, 450, -2);
gnome-applets/mixer/applet.c:963:  gtk_rc_style_unref (rc_style);
gnome-applets/modemlights/modem-applet.c:269:  gtk_rc_style_unref (rc_style);
gnome-applets/modemlights/modem-applet.c:463:      priv->progress_id = gtk_timeout_add (200, (GSourceFunc) pulse_progressbar, priv->report_window_progress);
gnome-applets/accessx-status/applet.c:1179:        gtk_rc_style_unref (rc_style);
gnome-applets/stickynotes/stickynotes_applet_callbacks.c:213:	gtk_rc_style_unref (rc_style);

fixed the gswitchit part

I've fixed the rest up. What I don't understand is why -DGTK_DISABLE_DEPRECATED didn't pick these up. Curious.

still one left: :(
gnome-applets/mini-commander/src/command_line.c:510:    mc->entry = gtk_entry_new_with_max_length ();

Also bug #570740 is closely related and the patch should not take long to review. It would be great to have that fixed as well :)

Oops, added the extra function call needed, but didn't change the constructor. Fixed.

570740 is one of two bugs I want to close before rolling the next tarball. It should be closed soon.

You rock :)

with 570740 gnome-applets can be marked as done for the deprecated GTK symbols goal.

Reopening because of GTK_WIDGET_TOPLEVEL usage:
./sound-theme/gvc-sound-theme-editor.c:
  if (GTK_WIDGET_TOPLEVEL (toplevel) != FALSE)

Fixed by other commits already.