After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562200 - Left click of mouse disables calendar
Left click of mouse disables calendar
Status: RESOLVED FIXED
Product: Evolution Exchange
Classification: Deprecated
Component: Connector
2.25.x
Other Linux
: Normal normal
: ---
Assigned To: Milan Crha
Ximian Connector QA
Depends on:
Blocks:
 
 
Reported: 2008-11-25 06:08 UTC by Akhil Laddha
Modified: 2009-01-12 12:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
proposed eds patch (3.69 KB, patch)
2009-01-09 17:48 UTC, Milan Crha
committed Details | Review

Description Akhil Laddha 2008-11-25 06:08:40 UTC
Evolution 2.25.2 (Exchange)

Local calendars and GW provider work fine.
Ideally left click should select calendar, not disable it.
Comment 1 Milan Crha 2009-01-09 17:36:41 UTC
If does GtkTreeView, in gtk_tree_view_button_press, it looks for the first visible column and calls "activate" method, which, for pixbuf renderer does nothing, but for a toggle renderer it toggles it.

We can either force to use the pixbuf renderer always, or make a subclass of the toggle renderer and ignore those button events, which comes out of the cell area. 

I'll go the second way, because it seems more correct than the first option to me.
Comment 2 Milan Crha 2009-01-09 17:48:32 UTC
Created attachment 126125 [details] [review]
proposed eds patch

for evolution-data-server;

Subclassing in the e-source-selector.c only. It would be nice to have a gtk+ property for this thing, to avoid subclassing because of such simple thing.
Comment 3 Srinivasa Ragavan 2009-01-12 04:18:09 UTC
Seems fine to trunk/stable
Comment 4 Suman Manjunath 2009-01-12 04:25:06 UTC
Patch committed to stable (gnome-2-24) branch as r9916
http://svn.gnome.org/viewvc/evolution-data-server?view=revision&revision=9916

Patch committed to SVN trunk as r9917
http://svn.gnome.org/viewvc/evolution-data-server?view=revision&revision=9917