After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562160 - Plus and Minus buttons potentially ambiguous: Better ways to add and remove photosa
Plus and Minus buttons potentially ambiguous: Better ways to add and remove p...
Status: RESOLVED FIXED
Product: postr
Classification: Other
Component: General
0.12
Other All
: Normal minor
: ---
Assigned To: Postr Maintainers
Postr Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-24 18:46 UTC by Nick Richards
Modified: 2009-12-15 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for option a) , buttons with text (3.14 KB, patch)
2009-11-26 12:55 UTC, Sergio Infante Montero
committed Details | Review

Description Nick Richards 2008-11-24 18:46:07 UTC
The plus and minus buttons at the bottom of the photo tray are potentially ambiguous where they are. They are both too small to stand on their own and usually too far away from the action (the selected photo or selection of photos) to have a good contextual relationship. There are a couple of options to make it better.

a)

Make the buttons more textual and make them take up more space (a whole row) like so:

|                       |
|                       |
|                       |
------------------------|
| Add photo             |
------------------------|
| Remove selected photo |
-------------------------

Or b)

Keep the add photo button on its own at the bottom of the list as mentioned above and insert the remove photo button inline with the selected photo

|                 |
|-----------------|
|                 |
|                 |
|     Photo A     |
|                 |
|                 |
|-----------------|
|           |  -  |
|           ------|
|                 |

It would also be good to have a remove action on right click of the photo.

Other information:
Comment 1 Sergio Infante Montero 2009-11-26 12:55:27 UTC
Created attachment 148529 [details] [review]
Patch for option a) , buttons with text

This is patch for option

a)

Make the buttons more textual and make them take up more space (a whole row)
like so:

|                       |
|                       |
|                       |
------------------------|
| Add photo             |
------------------------|
| Remove selected photo |
-------------------------
Comment 2 Germán Poo-Caamaño 2009-12-15 15:53:20 UTC
Review of attachment 148529 [details] [review]:

I committed it with some changes.  I used the same strings shown in the menu.

Thanks.
Comment 3 Germán Poo-Caamaño 2009-12-15 16:03:58 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.