After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561963 - Remove deprecated GTK+ symbols
Remove deprecated GTK+ symbols
Product: system-monitor
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks: 585692
Reported: 2008-11-22 22:13 UTC by Maxim Ermilov
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30

patch for this bug (823 bytes, patch)
2008-11-22 22:22 UTC, Maxim Ermilov
committed Details | Review
replace deprecated gdk_window_get_size with gdk_drawable_get_size (541 bytes, patch)
2009-02-26 00:03 UTC, Thomas Andersen
committed Details | Review
Replace gtk_widget_get_action with gtk_activatable_get_related_action (799 bytes, patch)
2009-04-07 10:45 UTC, Thomas Andersen
committed Details | Review

Description Maxim Ermilov 2008-11-22 22:13:12 UTC
I'm working on implementing
Comment 1 Maxim Ermilov 2008-11-22 22:22:39 UTC
Created attachment 123244 [details] [review]
patch for this bug
Comment 2 Benoît Dejean 2008-11-25 23:47:50 UTC
Thanks :)

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 3 André Klapper 2009-02-22 17:11:59 UTC

$:andre\> grep -r gdk_window_get_size .
./src/procman.cpp:	gdk_window_get_size (data->app->window, &width, &height);

$:andre\> grep -r gtk_widget_get_action .
./src/interface.cpp:	action = gtk_widget_get_action(GTK_WIDGET(proxy));
Comment 4 Thomas Andersen 2009-02-26 00:03:00 UTC
Created attachment 129528 [details] [review]
replace deprecated gdk_window_get_size with gdk_drawable_get_size

Trivial patch for gdk_window_get_size.

gdk_window_get_size simply is:
#define gdk_window_get_size gdk_drawable_get_size
Comment 5 Thomas Andersen 2009-03-02 00:51:52 UTC

very trivial patch for gdk_window_get_size. 

gtk_widget_get_action is first deprecated for 2.16
Comment 6 André Klapper 2009-03-31 12:07:17 UTC
Benoît, can this one-liner please get in?
Comment 7 Thomas Andersen 2009-04-07 10:45:59 UTC
Created attachment 132256 [details] [review]
Replace gtk_widget_get_action with gtk_activatable_get_related_action

Patch for the last case of deprecated gtk symbols in gnome-system-monitor.

gtk_activatable_get_related_action requires gtk 2.16 so bumping that too.
Comment 8 Frederic Peters 2009-04-18 12:43:28 UTC
Benoit, could that last one go in ?
Comment 9 Benoît Dejean 2009-04-18 20:35:14 UTC
Sorry Frederic, i was waiting for my Debian/Sid to update its libgtk.

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 10 André Klapper 2010-04-12 16:56:46 UTC
Reopening as gnome-system-tools uses GTK_WIDGET_TOPLEVEL:

      if (GTK_WIDGET_TOPLEVEL (parent) && GTK_IS_WINDOW (parent))
Comment 11 Kjartan Maraas 2010-04-14 19:03:01 UTC
gnome-system-tools is a different module :-)