GNOME Bugzilla – Bug 561956
Remove deprecated GTK+ symbols
Last modified: 2010-06-11 04:36:54 UTC
I'm working on implementing http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/GTK%2B
Created attachment 123241 [details] [review]
patch for this bug
Grepping still shows the following:
gdm/gui/user-switch-applet/applet.c:319: gtk_rc_style_unref (rc_style);
gdm/gui/simple-greeter/libnotificationarea/obox.c:76: klass = GTK_WIDGET_CLASS (gtk_type_class (GTK_TYPE_HBOX));
gdm/gui/simple-greeter/libnotificationarea/obox.c:79: klass = GTK_WIDGET_CLASS (gtk_type_class (GTK_TYPE_VBOX));
Created attachment 128710 [details] [review]
Replace deprecated symbols
Committed in r6707:
Removing the comment
/* Did you already see this code? Yes, it's gtk_tooltips_force_window() ;-) */
would be very appreciated and avoid getting false positives.
Reopening as GTK_WIDGET_FLAGS, GTK_WIDGET_STATE, GTK_WIDGET_TOPLEVEL are used.
GTK_WIDGET_FLAGS (adata->menubar) | GTK_CAN_FOCUS);
GTK_WIDGET_STATE (widget), GTK_SHADOW_IN,
gtk_paint_focus (widget->style, widget->window, GTK_WIDGET_STATE (widget),
if (toplevel && GTK_WIDGET_TOPLEVEL (toplevel) && GTK_IS_WINDOW (toplevel))
(this code is commented still it should be updated)
GTK_WIDGET_STATE has been fixed in the meantime (maybe by bug 612472) and GTK_WIDGET_FLAGS would be fixed by bug 612472. GTK_WIDGET_TOPLEVEL remains.
GTK_WIDGET_TOPLEVEL is in #if 0.
GTK_WIDGET_FLAGS is covered by 612472. Adding dependency.
Going to leave the #if 0'd one in there because it is a copy of the gnome-panel code.