After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561956 - Remove deprecated GTK+ symbols
Remove deprecated GTK+ symbols
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on: 612472
Blocks: 585692
 
 
Reported: 2008-11-22 21:33 UTC by Maxim Ermilov
Modified: 2010-06-11 04:36 UTC
See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30


Attachments
patch for this bug (1.34 KB, patch)
2008-11-22 21:39 UTC, Maxim Ermilov
committed Details | Review
Replace deprecated symbols (1.23 KB, patch)
2009-02-14 10:46 UTC, Thomas Andersen
committed Details | Review

Description Maxim Ermilov 2008-11-22 21:33:30 UTC
I'm working on implementing http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/GTK%2B
Comment 1 Maxim Ermilov 2008-11-22 21:39:08 UTC
Created attachment 123241 [details] [review]
patch for this bug
Comment 2 Matthias Clasen 2008-11-26 04:58:23 UTC
Thanks, committed.
Comment 3 Thomas Andersen 2009-02-14 10:42:04 UTC
Grepping still shows the following:

gdm/gui/user-switch-applet/applet.c:319:        gtk_rc_style_unref (rc_style);
gdm/gui/simple-greeter/libnotificationarea/obox.c:76:      klass = GTK_WIDGET_CLASS (gtk_type_class (GTK_TYPE_HBOX));
gdm/gui/simple-greeter/libnotificationarea/obox.c:79:      klass = GTK_WIDGET_CLASS (gtk_type_class (GTK_TYPE_VBOX));
Comment 4 Thomas Andersen 2009-02-14 10:46:21 UTC
Created attachment 128710 [details] [review]
Replace deprecated symbols
Comment 5 Ray Strode [halfline] 2009-02-16 21:52:47 UTC
Thanks Thomas.
Comment 6 Thomas Andersen 2009-02-16 22:20:41 UTC
Committed in r6707:
http://svn.gnome.org/viewvc/gdm?view=revision&revision=6707
Comment 7 André Klapper 2009-02-18 04:05:34 UTC
Removing the comment

./gui/simple-greeter/libnotificationarea/fixedtip.c:
/* Did you already see this code? Yes, it's gtk_tooltips_force_window() ;-) */

would be very appreciated and avoid getting false positives.
Comment 8 Ray Strode [halfline] 2009-07-16 18:06:55 UTC
Dropped.
Comment 9 André Klapper 2010-04-12 16:49:47 UTC
Reopening as GTK_WIDGET_FLAGS, GTK_WIDGET_STATE, GTK_WIDGET_TOPLEVEL are used.

./gui/user-switch-applet/applet.c:
    GTK_WIDGET_FLAGS (adata->menubar) | GTK_CAN_FOCUS);

./gui/simple-greeter/gdm-scrollable-widget.c:
    GTK_WIDGET_STATE (widget), GTK_SHADOW_IN,
./gui/user-switch-applet/applet.c:
    gtk_paint_focus (widget->style, widget->window, GTK_WIDGET_STATE (widget),

./gui/simple-greeter/libnotificationarea/fixedtip.c:
    if (toplevel && GTK_WIDGET_TOPLEVEL (toplevel) && GTK_IS_WINDOW (toplevel))
(this code is commented still it should be updated)
Comment 10 André Klapper 2010-05-04 11:36:02 UTC
GTK_WIDGET_STATE has been fixed in the meantime (maybe by bug 612472) and GTK_WIDGET_FLAGS would be fixed by bug 612472. GTK_WIDGET_TOPLEVEL remains.
Comment 11 André Klapper 2010-05-28 11:30:22 UTC
GTK_WIDGET_TOPLEVEL is in #if 0.
GTK_WIDGET_FLAGS is covered by 612472. Adding dependency.
Comment 12 William Jon McCann 2010-06-11 04:36:54 UTC
Going to leave the #if 0'd one in there because it is a copy of the gnome-panel code.