After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561931 - Shared music doesn't remember it was closed when reopening Banshee
Shared music doesn't remember it was closed when reopening Banshee
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: DAAP
1.4.1
Other All
: Normal minor
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-22 17:39 UTC by Michael Martin-Smucker
Modified: 2009-02-17 20:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Saving the expanded state. (1.21 KB, patch)
2009-02-17 03:55 UTC, Alexander Kojevnikov 		committed Details | Review

Description Michael Martin-Smucker 2008-11-22 17:39:12 UTC 
Sometimes I like to have the Shared Music item in the left panel open (with the arrow pointing down), but usually I like to have it closed (with the arrow pointing right).  Regardless of how this is set when I quit Banshee, Shared Music is always open (arrow pointing down) the next time I start Banshee.  Shared Music should behave the same way as other items in the left panel (like last.fm) and remember how it was set when Banshee was closed.
Comment 1 Bertrand Lorentz 2008-11-23 17:41:37 UTC 
A quick look at the source code shows that the current state (open/closed) of the "Shared Music" item is not stored.
The relevant file is src/Extensions/Banshee.Daap/Banshee.Daap/DaapContainerSource.cs

I guess it would be easy to implement, using the Last.fm code as an example : in src/Extensions/Banshee.Lastfm/Banshee.Lastfm.Radio/LastfmSource.cs, the Expand and AutoExpand properties.

As I'm not using DAAP, it would be pointless for me to work on that. Any takers ?
Comment 2 Alexander Kojevnikov 2009-02-17 03:55:49 UTC 
Created attachment 128884 [details] [review]
Saving the expanded state.

This patch does the trick. As Bertrand suggested I copy/pasted and adapted the code from the Last.fm extension, let me know if something is not right.
Comment 3 Gabriel Burt 2009-02-17 20:19:45 UTC 
Thanks, committed!