After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561221 - Don't allow file bookmarks
Don't allow file bookmarks
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
: 437989 580146 597389 (view as bug list)
Depends on:
Blocks: document-centric filechooser-nautilus
 
 
Reported: 2008-11-17 15:07 UTC by Sebastien Bacher
Modified: 2018-12-27 19:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24



Description Sebastien Bacher 2008-11-17 15:07:02 UTC
the bug has been described on https://bugs.launchpad.net/bugs/298425

"When running gtk apps like GIMP, and choose File->Open, filechooser dialog pops up, drag a file lke "picture.png" into the "Places" panel. Now each time when u click this file in the "places" panel, will go to the directory where it is held and highlight that file.

open nautilus now, and that file will also appear in the 'places' panel. However clicking it produces error
"not a directory" and does not go to that directory where file is held.

Not consistent and confusing to user. Whats the point of having that item in 'nautilus' if cant acess it."
Comment 1 Sebastien Bacher 2009-04-24 17:20:38 UTC
*** Bug 580146 has been marked as a duplicate of this bug. ***
Comment 2 Cosimo Cecchi 2010-05-06 17:45:10 UTC
*** Bug 597389 has been marked as a duplicate of this bug. ***
Comment 3 Dmitry Shachnev 2010-07-14 12:49:30 UTC
Will anybody at least mark it as confirmed? It was reported 2 years ago!
Comment 4 Dmitry Shachnev 2010-07-14 12:50:56 UTC
And, of course, it's still present in Gnome 2.31.
Comment 5 Cosimo Cecchi 2011-06-27 20:36:29 UTC
My two cents on this is the current Nautilus sidebar design is not targeting files as bookmarks, so just showing files there is indeed confusing and suboptimal. IMHO the right fix for this bug would be to hide those bookmarks which are not folders from the Nautilus sidebar completely (and possibly fix the file chooser not to add a bookmark on drag there, as here on F15 the 'Add' button is already made insensitive for non-folder items).

On a high-level view, I think we want to move towards field-specific file management with ad-hoc applications (see e.g. [1] and [2]), and it makes a lot of sense to 'star/add to favorites' files from there. That information could then be exported to e.g. the file chooser for easy access from any application.

[1] https://live.gnome.org/Design/Apps/Documents
[2] https://live.gnome.org/Design/Apps/Photos
Comment 6 William Jon McCann 2012-08-16 01:40:37 UTC
I don't think adding file bookmarks is desirable. We certainly don't want this in Nautilus because dragging files to the bookmarks side bar should be primarily for moving things. Having two very different results is bad news.

I just don't think it is worthwhile to have files there. I think one should bookmark locations.

I think we should modify the file chooser to be consistent with Nautilus here. I'm going to reassign the bug.
Comment 7 Federico Mena Quintero 2012-08-16 19:08:34 UTC
The ability to bookmark files was introduced in commit c100ebd2dafcd.

I'm ambivalent these days as to whether it is generally useful - I've probably used it two or three times since 2005...
Comment 8 Timothy Arceri 2013-05-21 07:30:15 UTC
*** Bug 437989 has been marked as a duplicate of this bug. ***
Comment 9 Federico Mena Quintero 2013-05-22 22:41:29 UTC
Thanks for resurrecting this, Timothy.

I just fixed this in the master branch, in commits dc2fe99dd0 and e6dca05445.  One can no longer bookmark files; just folders are allowed.