After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561185 - pangocairo backend sets antialias incorrectly
pangocairo backend sets antialias incorrectly
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-17 11:05 UTC by Christian Persch
Modified: 2008-11-18 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Persch 2008-11-17 11:05:23 UTC
case VTE_ANTI_ALIAS_FORCE_ENABLE:
        case VTE_ANTI_ALIAS_FORCE_DISABLE:
                font_options = cairo_font_options_copy (pango_cairo_context_get_font_options (context));
                cairo_font_options_set_antialias (font_options, antialias == VTE_ANTI_ALIAS_FORCE_ENABLE);
                pango_cairo_context_set_font_options (context, font_options);

So, if FORCE_ENABLE it sets antialias to 1, which is CAIRO_ANTIALIAS_NONE, otherwise to 0 which is CAIRO_ANTIALIAS_DEFAULT. This is obviously wrong :)

For FORCE_DISABLE, CAIRO_ANTIALIAS_NONE is the right value. I'm not sure what to use for FORCE_ENABLE in case the gdkscreen's font options don't have antialias set: use DEFAULT, GRAY or SUBPIXEL?

FORCE_ENABLE is only used by g-t to force the xft backend to antialias even when no xrender is present; is this necessary at all with the pangocairo backend?
Comment 1 Behdad Esfahbod 2008-11-18 13:20:22 UTC
DEFAULT sounds right.  For now I make it do that.  For vte 1.0, lets just get rid of this setting completely.
Comment 2 Behdad Esfahbod 2008-11-18 13:23:45 UTC
2008-11-18  Behdad Esfahbod  <behdad@gnome.org>

        Bug 561185 – pangocairo backend sets antialias incorrectly

        * src/vtepangocairo.c (font_info_create_for_screen): Handle 
        FORCE_ENABLE correctly.