*** Bug 561082 has been marked as a duplicate of this bug. ***

Crash is due to this..

+ Trace 209900

uids is NULL and qsort (uids->pdata, uids->len, sizeof (void *), uid_compar) crashes.

But I don't understand how uids can be NULL. Below is the code.

static void
imap_expunge (CamelFolder *folder, CamelException *ex)
{
	CamelImapStore *store = CAMEL_IMAP_STORE (folder->parent_store);
	GPtrArray *uids;
	int i, count;
	CamelMessageInfo *info;

	uids = g_ptr_array_new ();
	count = camel_folder_summary_count (folder->summary);
	for (i = 0; i < count; i++) {
		info = camel_folder_summary_index (folder->summary, i);
		if (camel_message_info_flags(info) & CAMEL_MESSAGE_DELETED)
			g_ptr_array_add (uids, g_strdup (camel_message_info_uid (info)));
		camel_message_info_free(info);
	}

	if (CAMEL_OFFLINE_STORE (store)->state == CAMEL_OFFLINE_STORE_NETWORK_AVAIL)
		imap_expunge_uids_online (folder, uids, ex);
	else
		imap_expunge_uids_offline (folder, uids, ex);

	for (i = 0; i < uids->len; i++)
		g_free (uids->pdata[i]);
	g_ptr_array_free (uids, TRUE);
}

Hi srag,

you imap_expunge code does not match what I have from SVN:

static void
imap_expunge (CamelFolder *folder, CamelException *ex)
{
        CamelImapStore *store = CAMEL_IMAP_STORE (folder->parent_store);
        GPtrArray *uids;

        camel_folder_summary_save_to_db (folder->summary, ex);
        uids = camel_db_get_folder_deleted_uids (folder->parent_store->cdb_r, folder->full_name, ex);

        if (CAMEL_OFFLINE_STORE (store)->state == CAMEL_OFFLINE_STORE_NETWORK_AVAIL)
                imap_expunge_uids_online (folder, uids, ex);
        else
                imap_expunge_uids_offline (folder, uids, ex);

        g_ptr_array_foreach (uids, (GFunc) camel_pstring_free, NULL);
        g_ptr_array_free (uids, TRUE);
}


But... looking at the version on this bug, it makes a bit of a sense: this is not about SVN, but 2.24.1 (which sports the code you show).

So I went into camel_db_get_folder_deleted_uids -- it pretty much runs a SQL query:

camel_db_get_folder_deleted_uids (CamelDB *db, char *folder_name, CamelException *ex)
{
         char *sel_query;
         int ret;
         GPtrArray *array = g_ptr_array_new();
         
         sel_query = sqlite3_mprintf("SELECT uid FROM %Q where deleted=1", folder_name);

         ret = camel_db_select (db, sel_query, read_uids_callback, array, ex);
         sqlite3_free (sel_query);

         if (!array->len || ret != 0) {
                 g_ptr_array_free (array, TRUE);
                 array = NULL;
         }
                 
         return array;
}

I then looked at my Evo log, and I see this at the end:

camel_db_select:
SELECT uid FROM 'BusinessRelated' where deleted=1 

===========
DB SQL operation [SELECT uid FROM 'BusinessRelated' where deleted=1] started
DB Operation ended. Time Taken : 0.000375
###########

(evolution:24370): camel-WARNING **: Error in select statement 'SELECT uid FROM 'BusinessRelated' where deleted=1' [no such table: BusinessRelated].


(By the way, the table *should* exist.)

If the folder wan't even visited once or if the folder is empty, it wont have a table for it.

Created attachment 122909 [details] [review]
Proposed patch

This must fix this.

Confirmed on trunk.

IN my case the folder is a IMAP high-level folder, with only sub-folders under it.

Mine was a junk folder on an IMAP inbox.  The inbox was not empty, but the junk folder was (had just been deleted).

This is not easily reproducible, so I can't verify it works.

Even if there was nothing to expunge, it can crash.

Committed to stable/trunk

*** Bug 544438 has been marked as a duplicate of this bug. ***

*** Bug 561507 has been marked as a duplicate of this bug. ***

*** Bug 562090 has been marked as a duplicate of this bug. ***

*** Bug 554689 has been marked as a duplicate of this bug. ***