After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560927 - Add devicekit
Add devicekit
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2008-11-15 15:37 UTC by Jaap A. Haitsma
Modified: 2008-12-28 20:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (1.31 KB, patch)
2008-11-15 15:48 UTC, Jaap A. Haitsma
none Details | Review
Take 2 (2.79 KB, patch)
2008-11-26 22:23 UTC, Luca Ferretti
none Details | Review
Take 3 (1.58 KB, patch)
2008-11-26 22:29 UTC, Luca Ferretti
committed Details | Review

Description Jaap A. Haitsma 2008-11-15 15:37:28 UTC
gnome power manager now uses it
Comment 1 Frederic Peters 2008-11-15 15:41:23 UTC
Are tarballs of DeviceKit available?
Comment 2 Jaap A. Haitsma 2008-11-15 15:48:01 UTC
Created attachment 122732 [details] [review]
Patch

Only dependency that's missing in libudev. udev is somehow already in jhbuild with libvolume_id but that somehow does not produce libudev?

So if anybody knows how to do that the above patch can be applied to get DeviceKit in jhbuild
Comment 3 Jaap A. Haitsma 2008-11-15 16:05:02 UTC
(In reply to comment #1)
> Are tarballs of DeviceKit available?
> 

I just found tarballs of DeviceKit and DeviceKit-power overhere
http://hal.freedesktop.org/releases/
Of DeviceKit-disks there does not seem to be tarball yet

Comment 4 Frederic Peters 2008-11-15 16:19:14 UTC
I don't think jhbuild should go as deep as udev (as it doesn't make sense to install udev in a different prefix)

Also about my request for tarballs, it was because I thought it would be an external dependency for gnome-power-manager, but I just checked and gnome-power-manager connects to DeviceKit through D-Bus (with a helper library, libdevkit-power, which is part of gnome-power-manager); so there is no absolute dependency there, on a first glance.

Comment 5 Luca Ferretti 2008-11-26 22:22:13 UTC
(In reply to comment #4)
> I don't think jhbuild should go as deep as udev (as it doesn't make sense to
> install udev in a different prefix)

If I'm right DeviceKit needs libudev >= 130, released on 07-Oct-2008.

So I think we need to include it in jhbuild, not all distros are using it...

> Also about my request for tarballs, it was because I thought it would be an
> external dependency for gnome-power-manager

Can't we add git checkouts in freedesktop*.modules now and move to tarballs in gnome-external-deps*.module later (when officially approved)?
Comment 6 Luca Ferretti 2008-11-26 22:23:50 UTC
Created attachment 123496 [details] [review]
Take 2

Fix up dependencies, list deps non managed in jhbuild for DeviceKit-disks
Comment 7 Luca Ferretti 2008-11-26 22:29:43 UTC
Created attachment 123499 [details] [review]
Take 3

Removed gyspy cuft from previous patch.
Comment 8 Luca Ferretti 2008-11-26 22:30:25 UTC
Of course there is no "udev" module in jhbuild... But I hope it will :)
Comment 9 Frederic Peters 2008-11-26 22:53:09 UTC
As I wrote previously I don't think it makes sense to install udev in a different prefix; from my point of view the installation and configuration of udev definitely belongs to the distributions, as it is a system thing.

I would like to be proved otherwise, you "just" have to explain me how to get udev installed in a different prefix working fine with the distribution-shipped udev.
Comment 10 Frederic Peters 2008-11-26 22:55:11 UTC
Richard, could you enlighten me/us?
Comment 11 Richard Hughes 2008-11-27 09:36:21 UTC
You need to install udev system-wide. When you've installed 130, DeviceKit should build fine. Once you've got DeviceKit, you can build DeviceKit-power.

And you're right -- g-p-m doesn't have a library dep on DeviceKit-power, but if you compile with --enable-devicekit you'll need DeviceKit installed for it to do anything useful.
Comment 12 Frederic Peters 2008-11-27 12:15:59 UTC
Thanks for the quick answer Richard.

At the moment, on a system without libudev, so no DeviceKit possible, running gnome-power-manager configure script, without any parameter, sets it as DeviceKit-power enabled:
        DeviceKit-power support:   yes
So this will make it useless for those people building GNOME with jhbuild.

You told me on desktop-devel-list it would be too hard to check at runtime, but what about checking on build time?  Would it be possible?
Comment 13 Richard Hughes 2008-11-27 13:40:30 UTC
I guess we could check at build time, and look for devkit-gobject. One thing to note -- I'm not building myself the HAL code in trunk, so it might be broken. Long term I want to rip the HAL code out.

Richard.
Comment 14 Frederic Peters 2008-11-27 13:45:35 UTC
It would really help if it could be checked on build time, do you want a bug report about this?
Comment 15 Frederic Peters 2008-12-28 14:34:29 UTC
Request filed against gnome-power-manager as bug 565867.

Luca: could you commit your patch, after removing the udev part?
Comment 16 Luca Ferretti 2008-12-28 20:11:03 UTC
Landed in revision 2605, without udev.

http://svn.gnome.org/viewvc/jhbuild/trunk/modulesets/freedesktop-2.26.modules?r1=2546&r2=2605