After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560726 - "View" > "Switcher Appearance" cleanup
"View" > "Switcher Appearance" cleanup
Status: RESOLVED DUPLICATE of bug 271482
Product: evolution
Classification: Applications
Component: Shell
2.24.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
evolution[kill-bonobo]
Depends on:
Blocks:
 
 
Reported: 2008-11-14 00:28 UTC by Paul Bolle
Modified: 2009-12-16 22:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
"View" > "Switcher Appearance" cleanup (11.22 KB, patch)
2008-11-14 00:33 UTC, Paul Bolle 		reviewed Details | Review
[RFC] reword and reorganize View > "Switcher Appearance" menu items (4.33 KB, patch)
2009-12-10 11:53 UTC, Paul Bolle 		none Details | Review

Description Paul Bolle 2008-11-14 00:28:14 UTC 
0) There is currently a "View" > "Switcher Appearance" menu item. It needs a cleanup:
    s/Switcher Appearance/Switcher/
    make "Hide Buttons" the top entry of the submenu (and not the bottom entry)
    s/Hide Buttons/Show Switcher/
    the tooltip entries talk about "window buttons". How about "Component buttons"?

1) I'll try to attach a patch that illustrates my idea.
Comment 1 Paul Bolle 2008-11-14 00:33:56 UTC 
Created attachment 122622 [details] [review]
"View" > "Switcher Appearance" cleanup

Note that the "Buttons" idiom is rooted deeply in the code. This patch just replaces the the top layer with the Switcher idiom (which I prefer).

If this is accepted it might be better to adjust all the code to the new idiom (except for the naming of the gconf entry?).

No ChangeLog entry yet. Will add one after this is reviewed and ACK'ed.
Comment 2 Matthew Barnes 2008-11-14 02:05:00 UTC 
The changes you're suggesting look reasonable but the code you're modifying is not long for this world.

You might want to have a look at the "kill-bonobo" branch, which will hopefully be merged before 2.26, and try patching that.  I can help with any build issues you run into.

(Background info: http://www.go-evolution.org/KillBonobo)
Comment 3 Paul Bolle 2009-12-10 11:53:12 UTC 
Created attachment 149514 [details] [review]
[RFC] reword and reorganize View > "Switcher Appearance" menu items

0) Just a small step: reword and reorganize View > "Switcher Appearance" menu items. Basically moves from:
    View
       Switcher Appearance
          [...]
          ----------------
          [x] Show Buttons
to:
    View
       Switcher
          [x] Show Switcher
          -----------------
          [...]

1) Untested. But something similar works on 2.29.3 (I had trouble cherry picking my local commit into master).

2) Please check the other string changes on spelling, capitalization, and style.

3) Next step should be enabling/disabling the four entries below the separator depending on the "Show Switcher" check box state (or has that already been implemented in master?).

4) Note that bug #271482 might make this bug moot. In the mean time it still make sense to clean this (sub) menu.
Comment 4 Milan Crha 2009-12-16 20:21:39 UTC 
I guess Matt is on this, but from my point of view the changes seem straightforward.
Comment 5 Matthew Barnes 2009-12-16 22:20:13 UTC 
(In reply to comment #3)
> 4) Note that bug #271482 might make this bug moot. In the mean time it still
> make sense to clean this (sub) menu.

Yes, actually, let's merge this discussion into bug #271482.

Closing this as a dupe for lack of a better resolution.

*** This bug has been marked as a duplicate of bug 271482 ***