Bug 560445 - GNOME Goal: Remove deprecated GLib symbols
GNOME Goal: Remove deprecated GLib symbols
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
:
Depends on:
Blocks: 560423
  Show dependency tree
 
Reported: 2008-11-12 03:00 UTC by Luis Menina
Modified: 2008-11-12 10:06 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Luis Menina 2008-11-12 03:00:53 UTC 
See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/Glib
Here are the files+lines using deprecated GLib symbols in this module:

metacity/src/include/main.h:38:/* g_main_quit() then fall out of main() */
metacity/src/core/delete.c:494:              g_strcasecmp (w->res_class, "metacity-dialog") == 0)
Comment 1 Thomas Thurman 2008-11-12 03:56:58 UTC 
Well, the first one isn't a call, but okay :)  Fixed.
Comment 2 Luis Menina 2008-11-12 10:06:51 UTC 
Yes, sorry about that, but I'm using egrep to find the deprecated symbols. That way I avoid building every GNOME program for that. Using a thorough regexp slows down the process *a lot*, so I keep using a simple regexp to identify these symbols. Removing them in comments and dead code too allows me to avoid false positives. Thanks for the fix.
Note You need to log in before you can comment on or make changes to this bug.