After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560440 - GNOME Goal: Remove deprecated GLib symbols
GNOME Goal: Remove deprecated GLib symbols
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: logview
trunk
Other Linux
: Normal normal
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
Depends on:
Blocks: 560423
 
 
Reported: 2008-11-12 02:43 UTC by Luis Menina
Modified: 2008-12-23 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use g_ascii_strncasecmp (508 bytes, patch)
2008-11-12 22:19 UTC, Frederic Peters 		none Details | Review

Description Luis Menina 2008-11-12 02:43:10 UTC 
See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/Glib
Here are the files+lines using deprecated GLib symbols in this module:

gnome-utils/logview/logview.c:249:	if (selected!=NULL && g_strncasecmp (log->name, selected, -1)==0)
Comment 1 Frederic Peters 2008-11-12 22:19:15 UTC 
Created attachment 122529 [details] [review]
use g_ascii_strncasecmp

Replace g_strncasecmp by g_ascii_strncasecmp; as log->name is ascii (and treated as is in other functions of that file).
Comment 2 Luis Menina 2008-11-12 23:21:35 UTC 
is
g_ascii_strncasecmp (log->name, selected, -1)
the same as
g_ascii_strcasecmp (log->name, selected)
?
Comment 3 Frederic Peters 2008-11-13 08:25:10 UTC 
Yes; so this could as well use g_ascii_strcasecmp. (but note other strncasecmp calls are made with n = 255)
Comment 4 Cosimo Cecchi 2008-12-23 14:27:36 UTC 
Logview has been rewritten, so this is fixed in trunk.