After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560251 - [PATCH] Split g_ir_ffi_get_ffi_type() out from ginvoke.c
[PATCH] Split g_ir_ffi_get_ffi_type() out from ginvoke.c
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks: 560252
 
 
Reported: 2008-11-10 23:32 UTC by Owen Taylor
Modified: 2015-02-07 16:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch as described (8.21 KB, patch)
2008-11-10 23:34 UTC, Owen Taylor 		accepted-commit_now Details | Review

Description Owen Taylor 2008-11-10 23:32:19 UTC 
Extract a function to convert GITypeTag to ffi_type from the internals
of ginvoke.c. This will be useful in figure out structure alignment.

Also fix handling of gsize and time_t to be portable. (Add a check
to configure.ac to figure out the width of time_t.)
Comment 1 Owen Taylor 2008-11-10 23:34:16 UTC 
Created attachment 122371 [details] [review]
Patch as described
Comment 2 Colin Walters 2008-11-10 23:37:48 UTC 
Looks ok; a random thought is to split off g_function_info_invoke into girffi.h too.
Comment 3 Owen Taylor 2008-11-11 00:05:07 UTC 
I think it's better to keep girffi.h an uninstalled header until there are
concrete use cases outside of gobject-introspection.

Plus g_function_info_invoke() is a bit different in that it doesn't reveal
that libffi is involved ... it could be reimplemented using different
technology internally.

Patch pushed to svn.
Comment 4 André Klapper 2015-02-07 16:54:50 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]