After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560151 - Fix window resize to use exported usable area
Fix window resize to use exported usable area
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
2.22.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 572519 (view as bug list)
Depends on: 523574
Blocks:
 
 
Reported: 2008-11-10 14:38 UTC by Josselin Mouette
Modified: 2011-01-27 19:30 UTC
See Also:
GNOME target: 3.0
GNOME version: ---



Description Josselin Mouette 2008-11-10 14:38:43 UTC
[ Forwarded from http://bugs.debian.org/504366 by Matt Kraai ]

Totem refuses to resize a window to an aspect ratio if the resulting
width of the video is more than 128 pixels less than the width of the
screen.  On my system, the decorations on each side of the video are 5
pixels wide, so some videos cannot be resized even though there is
plenty of room to do so.

The attached patch changes the fudge-factor to 10, though it would
probably be better to determine the actual width (and height) of the
decorations and use those values instead.

[ Further notes (joss) ]

The patch Matt provided is trivial, I can attach it if you want. I agree that the size should be computed from the decorations size (including the menu and status bars for the vertical one) instead of hardcoding it.
Comment 1 Bastien Nocera 2008-11-13 13:23:47 UTC
I wouldn't want to replace a hack by another, the only way to fix this is to have bug 523574 fixed in GTK+.

*** This bug has been marked as a duplicate of 416610 ***
Comment 2 Bastien Nocera 2008-11-13 13:26:16 UTC
Oops, wrong bug.
Comment 3 Philip Withnall 2009-02-20 08:57:19 UTC
*** Bug 572519 has been marked as a duplicate of this bug. ***
Comment 4 Bastien Nocera 2010-10-12 00:53:04 UTC
Code in gnome-desktop to do this:
http://git.gnome.org/browse/gnome-desktop/commit/?id=053a932b09487c4fa3e6331ef7fb65d24667263d

This is actually readable, and should probably be ifdef X11.
Comment 5 Bastien Nocera 2011-01-27 19:30:31 UTC
commit 3448cb53523494ce6a85f6e4abf37f9d6e61be05
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu Jan 27 19:10:28 2011 +0000

    backend: Use workspace area when resizing
    
    So that we don't have to use our horrible hard-coded offsets
    when calculating whether the video will fit on the screen.
    
    Also make sure we take into account the size of the window
    decorations, and parts of the UI other than the video widget.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=560151