GNOME Bugzilla – Bug 559863
RTL locales: icons in folder icon view are aligned to the left
Last modified: 2009-04-07 09:05:14 UTC
Please describe the problem: when using nautilus in right to left locales icons should be aligned to right this is not a gtk bug because the iconview in gtk-demo appears correctly so why nautilus forces a left alignment ? Steps to reproduce: 1. login with ar_EG.UTF-8 locale 2. open nautilus Actual results: icons are on the left Expected results: they should be on the right Does this happen every time? yes Other information:
Created attachment 122225 [details] screenshot of nautilus and gtk-demo notice that icons in nautilus are not placed in the prober place while in gtk-demo they are
Nautilus icon view does not use the gtkiconview widget
This was working fine after commit in bug #342009 Now the icons are laid out from right to left correctly, but then the whole icon view is aligned to the left.
Created attachment 125594 [details] [review] fix folder icon view icons alignment for RTL locales
I have no idea why the code removed in attachment #125594 [details] was added. I did notice that after it is removed on RTL compact view the bottom scrollbar is always visible. I believe it is much more important to have the alignment fixed before figuring out the scrollbar issue on compact view.
This is not a duplicate of bug #342009 because the patch that solved it was already applied in my version 2.24.2 http://cvs.fedora.redhat.com/viewvc/rpms/nautilus/F-10/ I'll test the patch in comment 3 and see
yes the patch worked for me
Created attachment 125660 [details] screen shot after fix
sorry I meant comment 4
Not a 2.26 blocker. @Yair: does the patch introduce other bugs in RTL? I can't test it at the moment.
In response to comment #10: Right now this is the most annoying bug in nautilus for RTL users, so i think we want it fixed in gnome 2.26. I haven't noticed any other (but the one mentioned in comment #5) ui bug since applying the patch on my local system.
Wake up call. This bug was missed in 2.26 and this means it would take more then a year to get a simple one line bug to be fixed. I would appreciate if this one line is reviewed so I can commit the patch.
The patch in this bug is wrong in other ways. A better fix commited: 2009-04-07 Alexander Larsson <alexl@redhat.com> Bug 559863 – RTL locales: icons in folder icon view are aligned to the left * libnautilus-private/nautilus-icon-container.c: (nautilus_icon_container_update_scroll_region): Fix up the icon view extents so that we always include the full window allocation in the automatic layout case, plus allow extents < 0 (due to layout in RTL mode). This makes sure we RTL auto-layouting works correctly instead of being flushed to the left.