GNOME Bugzilla – Bug 559839
Orca sometimes includes content from other lines when navigating via Up/Down Arrow in Firefox 3
Last modified: 2008-11-13 22:23:41 UTC
On occasion, using Up/Down Arrow to read the content of a web page will cause Orca to include content from the previous or next line. See for example: http://java.sun.com/javase/6/webnotes/install/jdk/install-linux.html The culprit are items which have extents of (0, 0, 0, 0). We used to get those extents erroneously quite a bit from Firefox so we included the associated content "just to be safe." Now that it's more rare, we can refine our check and get more accurate results for the line.
Created attachment 122219 [details] [review] revision 1 Pylinted and regression tested. I've also updated the two tests we have where this problem was visible. Please test.
Tentatively targeting this for 2.25.2 (as opposed to the 2.24.2 or 2.24.3 releases). While this is a seemingly minor change, I've been working with Firefox 3.1 for a long time now and using/testing in 3.0 far less. I'm hesitant to commit this to branch without it being seriously pounded on in 3.0 first. But I'm pretty confident about it for 3.1. <smile> Thoughts?
I've just given this one a couple hours of testing primarily with FF 3.0. I think it is safe at least for trunk.
Thanks Mike! Patch committed to trunk. Mike mentioned to me via IM that this patch in part improves a problem he's been having with accessing his personal information at his bank's site. In light of this, I'm going to retarget for 2.24.2. Mike: If you are using Firefox 3.0 primarily, it would be great if you could be on the lookout for potential side effects related to this patch. If you don't come across any between now and 2.24.2, we can check this patch into the gnome-2-24 branch. That way we still have 2.24.3 should we be wrong. :-)
This one seems like a winner.
Thanks Mike. Patch committed to the gnome-2-24 branch. Closing as FIXED.