After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559815 - Empty Reminders editor when opened second time
Empty Reminders editor when opened second time
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
3.4.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-11-07 23:02 UTC by Milan Crha
Modified: 2012-08-08 10:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
evo patch (1.26 KB, patch)
2012-08-08 09:58 UTC, Milan Crha 		committed Details | Review

Description Milan Crha 2008-11-07 23:02:12 UTC 
I found some strange issues with "Alarms" dialog:

a) Edit event, click the Alarm toolbar icon, the dialog is shown, hit Escape or the X window button, the dialog is hidden, then try to click the toolbar icon again, nothing happened in the UI, only on the console:
 Gtk-CRITICAL **: gtk_widget_show: assertion `GTK_IS_WIDGET (widget)' failed

b) Have an event with one alarm, edit the event, hit toolbar button for Alarms dialog, choose the alarm and hit Edit, there is another message on the console:
 GLib-GObject-WARNING **: invalid cast from `GtkOptionMenu' to `GtkMenuShell'
Comment 1 Matthew Barnes 2008-11-08 15:45:55 UTC 
I tried to reproduce this with Evolution 2.25.1 but wasn't able to generate either warning, and was able to bring up the Alarms dialog repeatedly.
Comment 2 Milan Crha 2008-11-10 16:28:37 UTC 
OK, let's see, maybe it's because of my gtk+ version? It's not so fresh. My gtk+ revision is 20300, Last Changed Date: 2008-06-03 09:29:12 +0200 (Tue, 03 Jun 2008), from trunk, while the Evolution's revision is 36769, Last Changed Date: 2008-11-10 11:29:30 +0100 (Mon, 10 Nov 2008), also from trunk.

The a) comes from

+ Trace 209586

  • #3 IA__gtk_widget_show
    at gtkwidget.c line 2957
  • #4 event_page_show_alarm
    at event-page.c line 2110
  • #5 action_alarms_cb
    at event-editor.c line 145
  • #2 IA__g_type_check_instance_cast
    at gtype.c line 3736
  • #3 populate_widgets_from_alarm
    at alarm-dialog.c line 646
  • #4 alarm_to_dialog
    at alarm-dialog.c line 238
  • #5 alarm_dialog_run
    at alarm-dialog.c line 1173
  • #6 edit_clicked_cb
    at alarm-list-dialog.c line 170 

Do you think I've really broken/too old gtk+?
Comment 3 André Klapper 2012-08-07 11:12:02 UTC 
Milan: Can you still reproduce this, or is this RESOLVED OBSOLETE?
Comment 4 Milan Crha 2012-08-08 09:37:25 UTC 
Nice, b_ is fixed in git master (3.5.5), but a) is still there. Even it doesn't show the warning, then the second click on the Reminders toolbar button opens the window, but it's totally empty, with no content.
Comment 5 Milan Crha 2012-08-08 09:58:32 UTC 
Created attachment 220653 [details] [review]
evo patch

for evolution;

Fix for this. the "destroy-notify" prototype returns TRUE for stop processing other handlers, while there was attached only gtk_widget_hide(), which returns void. With this change the dialog looks like it should.
Comment 6 Milan Crha 2012-08-08 10:02:40 UTC 
Created commit 5f0b2dd in evo master (3.5.90+)
Created commit c0d422b in evo gnome-3-4 (3.4.4+)