After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559740 - F-Spot creates a photo_versions for 'Original' version
F-Spot creates a photo_versions for 'Original' version
Status: RESOLVED NOTGNOME
Product: f-spot
Classification: Other
Component: General
SVN
Other Linux
: Normal normal
: 0.7.0
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-07 13:00 UTC by Maxxer
Modified: 2010-06-08 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't store original versions in photo_versions (1.65 KB, patch)
2008-12-01 21:02 UTC, Thomas Van Machelen 		none Details | Review

Description Maxxer 2008-11-07 13:00:03 UTC 
F-Spot creates a photo_versions row for 'Original' version, but this shouldn't happen.
Comment 1 Thomas Van Machelen 2008-11-07 14:10:37 UTC 
Problem is cause by 

1. Photo constructor calls AddVersionUnsafely for original photo id
2. AddVersionUnsafely performs changes.AddVersion

If the photo is then stored to the database is creates an entry in photo versions for the original photo because it is in VersionsAdded of the PhotoChanges
Comment 2 Thomas Van Machelen 2008-12-01 21:02:25 UTC 
Created attachment 123761 [details] [review]
Don't store original versions in photo_versions
Comment 3 Ruben Vermeersch 2010-05-25 12:52:46 UTC 
And why is this a bug?
Comment 4 Maxxer 2010-05-29 21:51:48 UTC 
(In reply to comment #3)
> And why is this a bug?

because with version 0 in photo_Versions, photo table is useless...
this table should hold only modifications.
Comment 5 Ruben Vermeersch 2010-05-29 22:49:13 UTC 
No, the real bug is the fact that this data is also in photos. Which doesn't make sense because it is only a property of a version (and original is a version too).
Comment 6 Ruben Vermeersch 2010-05-30 09:45:16 UTC 
well, not really, there are properties that apply to a photo, regardless of the version (e.g. the time it was taken). The filename though is specific to the version.