After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559703 - Virtual functions miss throws attribute in .gir
Virtual functions miss throws attribute in .gir
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jürg Billeter
gobject-introspection Maintainer(s)
Depends on:
Blocks: 559704
 
 
Reported: 2008-11-07 07:04 UTC by Jürg Billeter
Modified: 2015-02-07 16:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.32 KB, patch)
2008-11-07 07:05 UTC, Jürg Billeter
committed Details | Review

Description Jürg Billeter 2008-11-07 07:04:58 UTC
The GLibTransformer removes the GError parameter from virtual functions but the GIRWriter does not add a throws attribute.
Comment 1 Jürg Billeter 2008-11-07 07:05:49 UTC
Created attachment 122169 [details] [review]
Proposed patch

Ok to commit?
Comment 2 Colin Walters 2008-11-07 22:50:58 UTC
Looks good to me.
Comment 3 Jürg Billeter 2008-11-09 14:33:35 UTC
2008-11-09  Jürg Billeter  <j@bitron.ch>

	* giscanner/ast.py:
	* giscanner/girwriter.py:

	Write throws attribute for virtual functions, fixes bug 559703

Fixed in r871.
Comment 4 André Klapper 2015-02-07 16:44:43 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]