After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559631 - [PATCH] Drop glade implementation for error dialogs
[PATCH] Drop glade implementation for error dialogs
Status: RESOLVED FIXED
Product: muine
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Muine Maintainers
Muine Maintainers
Depends on:
Blocks: 572883
 
 
Reported: 2008-11-06 17:54 UTC by Priit Laes (IRC: plaes)
Modified: 2008-11-08 11:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Kill ErrorDialog's glade usage. (6.92 KB, patch)
2008-11-06 17:55 UTC, Priit Laes (IRC: plaes) 		committed Details | Review
Kill OverWriteDialog's glade usage. (7.83 KB, patch)
2008-11-06 18:15 UTC, Priit Laes (IRC: plaes) 		committed Details | Review
Updated TODO :) (989 bytes, patch)
2008-11-06 18:17 UTC, Priit Laes (IRC: plaes) 		committed Details | Review

Description Priit Laes (IRC: plaes) 2008-11-06 17:54:50 UTC 
TODO has following entry:

o Create message dialogs ourselves, not through glade
  Once we have Gtk 2.6 support in Gtk#


Currently ErrorDialog and OverWriteDialog use glade.


Patches coming...
Comment 1 Priit Laes (IRC: plaes) 2008-11-06 17:55:53 UTC 
Created attachment 122130 [details] [review]
Kill ErrorDialog's glade usage.
Comment 2 Priit Laes (IRC: plaes) 2008-11-06 18:15:53 UTC 
Created attachment 122131 [details] [review]
Kill OverWriteDialog's glade usage.
Comment 3 Priit Laes (IRC: plaes) 2008-11-06 18:17:16 UTC 
Created attachment 122133 [details] [review]
Updated TODO :)
Comment 4 Wouter Bolsterlee (uws) 2008-11-07 16:22:31 UTC 
The UI is the same, right? And this does not change any strings either, right?

Please commit.
Comment 5 Luis Medinas 2008-11-08 02:22:47 UTC 
Good work Priit please commit.
Comment 6 Priit Laes (IRC: plaes) 2008-11-08 11:36:37 UTC 
Committed as r1235.

Also updated POTFILES.in to pass distcheck :)