After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559582 - Cleanups for -DG_DISABLE_DEPRECATED
Cleanups for -DG_DISABLE_DEPRECATED
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 560423
 
 
Reported: 2008-11-06 12:14 UTC by Kjartan Maraas
Modified: 2009-12-28 09:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.95 KB, patch)
2008-11-06 12:15 UTC, Kjartan Maraas 		committed Details | Review
g_mapped_file_free (868 bytes, patch)
2009-12-03 23:24 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Substitute g_volume_* and g_mount_* deprecated symbols (60.79 KB, patch)
2009-12-26 13:40 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Use GNOME_MAINTAINER_MODE_DEFINES macro (759 bytes, patch)
2009-12-26 13:48 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Substitute g_volume_* and g_mount_* deprecated symbols.v2 (4.40 KB, patch)
2009-12-27 20:16 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review

Description Kjartan Maraas 2008-11-06 12:14:52 UTC 
Attaching a patch.
Comment 1 Kjartan Maraas 2008-11-06 12:15:25 UTC 
Created attachment 122091 [details] [review]
patch
Comment 2 Jonathan Matthew 2008-11-07 00:49:50 UTC 
Committed, thanks.

Some of these changes (under plugins/audiocd/) are in code copied from sound-juicer.  I notice you've filed a few of these bugs against other modules - is s-j on your list?
Comment 3 Kjartan Maraas 2008-11-07 10:48:16 UTC 
Yes, I've tested sound-juicer and found no problems there.
Comment 4 Bastien Nocera 2008-12-01 11:54:59 UTC 
Changes were made to those sound-juicer copied files and never committed to sound-juicer itself, and I can't find a bug opened against sound-juicer for those changes either.
Comment 5 Bastien Nocera 2008-12-18 10:09:29 UTC 
Fixed in sound-juicer now.
Comment 6 Javier Jardón (IRC: jjardon) 2009-12-03 23:24:52 UTC 
Created attachment 149054 [details] [review]
g_mapped_file_free

I've reopened this bug because there is a deprecated glib symbol in use: g_mapped_file_free()
Comment 7 Jonathan Matthew 2009-12-26 09:04:45 UTC 
Comment on attachment 149054 [details] [review]
g_mapped_file_free

committed, thanks.  I think it'd be better to open new bugs rather than reopening this one in future.
Comment 8 Javier Jardón (IRC: jjardon) 2009-12-26 13:40:22 UTC 
Created attachment 150403 [details] [review]
Substitute g_volume_* and g_mount_* deprecated symbols
Comment 9 Javier Jardón (IRC: jjardon) 2009-12-26 13:48:30 UTC 
Created attachment 150404 [details] [review]
Use GNOME_MAINTAINER_MODE_DEFINES macro

This macro will notify you if you use deprecated symbols
Comment 10 Jonathan Matthew 2009-12-27 05:14:35 UTC 
You attached the wrong patch there - it seems to be for bug 595425 (GSEAL) rather than this one.
Comment 11 Javier Jardón (IRC: jjardon) 2009-12-27 20:16:58 UTC 
Created attachment 150468 [details] [review]
Substitute g_volume_* and g_mount_* deprecated symbols.v2

Oops, sorry Jonathan, here the correct patch
Comment 12 Jonathan Matthew 2009-12-28 08:44:42 UTC 
Comment on attachment 150468 [details] [review]
Substitute g_volume_* and g_mount_* deprecated symbols.v2

I committed a slightly different version of this