After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559280 - gedit doesn't reuse maximized window, opens new window instead
gedit doesn't reuse maximized window, opens new window instead
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
2.24.x
Other All
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
: 549058 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-11-04 14:53 UTC by Vassily Gavrilyak
Modified: 2009-03-03 14:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24



Description Vassily Gavrilyak 2008-11-04 14:53:36 UTC
Please describe the problem:
When gedit window is maximized to the whole desktop using maximus from ubuntu-netbook of by using Compiz - remove decorations then new file will be opened in new windows instead of tab in last window

Steps to reproduce:
1. Using Compiz, in ccsm, in Window Decorations, there's a line "Decoration windows".
Replace the default "any" with "!state=maxvert"
2.Launch gedit and maximize window 
3.Launch gedit <somefile> again



Actual results:
New window will be opened

Expected results:
New tab shoule be opened

Does this happen every time?
yes, when window is maximized

Other information:
This make gedit slightly unconvinient to use on netbooks
Comment 1 Vassily Gavrilyak 2008-11-04 14:57:16 UTC
Proposed patch is
 
$ diff  gedit-app.c.orig gedit-app.c
665c665
< 	       y + height < viewport_y + sc_height;
---
> 	       y + height <= viewport_y + sc_height;

This worked good for me with compiz and maximized windows.
Comment 2 Paolo Borelli 2009-03-03 14:10:07 UTC
Sorry, this patch fell through the cracks and I failed to notice it! I committed it now and it will be in the next version. Thanks!

In the future make sure to attach the patch file instead of adding it as a comment so that it shows up on our patch summary. Also make sure to create the patch in uthe "unified diff" format, in other words specify the -u option to the diff command.
Comment 3 Paolo Borelli 2009-03-03 14:13:15 UTC
*** Bug 549058 has been marked as a duplicate of this bug. ***