GNOME Bugzilla – Bug 559013
Import Media dialogue box is confusing
Last modified: 2009-11-11 05:24:06 UTC
If you select either 'Local Folder' or 'Local Files' from the combo box in the import media dialogue, and then press the 'Import Media Source' button, a file/folder chooser dialogue is opened. This is confusing because 'Import Media Source' is not doing what its label suggests it would do. It doesn't import media - it opens a file chooser dialogue.
That the 'Import Media Source' triggers different behaviour depending on the option selected in the combo box is also potentially confusing.
I'm not sure what the answer to this one is. Something in the interface needs to change, though. Could the label on the button update to reflect the option selected in the combo box? Or what about using a wizard?
One potential solution: include 'Select local folder...' and 'Select local files...' options in the combo box. Selecting either of these would open the file chooser dialogue. Once the selection was completed, the combo box would display the selected files or folder.
Combo box displays default:
The user clicks on the combo box, which displays the following options:
'Videos from Photos Folder'
'Select local files...'
'Select local folder...'
They click on 'Select local folder...'. The file chooser opens and they select their 'Music' folder. The file chooser closes and the combo box updates to display 'Music'.
If the user clicks on the combo box again, they get:
'Videos from Photos Folder'
'Select local files...'
'Select local folder...'
The user selects the 'Import media source' button and the 'Music' folder is imported.
Created attachment 136087 [details] [review]
This patch extends the ImportDialog to show the import settings specific to the currently selected import source. This way, the user can edit all the settings from the dialogue, no additional prompts will be shown after the user clicks the "Import" button.
There are a couple of things I'm still not happy with:
* The import source combobox no longer updates when ImportSources are added/removed/updated. Let me know if you think that's an important feature.
* For the FileImportSource I use a read-only Entry to show the list of selected files + a button to change the selection. This looks a bit awkward but the standard FileChooserButton doesn't support multi-selection. Let me know if you have other ideas about how to handle this.
Forgot to mention, this patch makes it possible to finalise dependent bug 441093 and bug 532650.
Created attachment 136540 [details] [review]
Handle add/update/remove import sources + a better widget for the file importer
This patch fixes both issues mentioned in comment #3:
* The import dialogue updates the list of import sources as they are added/updated/removed.
* The widget that shows the list of selected files looks much better now, I will attach a screen-shot.
Created attachment 136541 [details]
List of files to import
Was just talking to Alexander about this on IRC:
I think we could reduce the # of steps and keep things simpler by changing the bottom-right button based on what import source is selected.
So for local files/folders, you'd get a checkbox or two or whatever in the current custom-widget area for import-ratings/playcounts etc, and the bottom-right button would read "Choose Folder..." or "Choose Files..." or similar.
If you had Amarok selected, it would read "Migrate from Amarok" or similar.
Alexander said he would research if the HIG says changing the button like this is a bad idea.
If nothing else, we should definitely line up the left edge of the dropdown with the left edge of the text above it.
> Alexander said he would research if the HIG says changing the button like this
> is a bad idea.
Snip from further IRC chat:
(09:50:02) alexkay: gabaug: it looks like changing the button text is a no-no: http://library.gnome.org/devel/hig-book/stable/controls-option-menus.html.en
(09:50:04) alexkay: Selecting an item from a drop-down list should not affect the values of any other controls. It may sensitize, insensitize, hide or show other controls, however.
(09:50:55) gabaug: alexkay: heh...well, we definitely break that w/ our current preferences, and with our current idea of adding custom widgetry at all beneath the import source dropdown
Our dropdown is actually a replacement for a Gtk.Notebook (we actually use a headerless notebook behind the scenes). Considering this I think replacing the ambiguous "Import Media Source" text with a concrete next action is a good thing. If there are not objections, I will update the patch.
> If nothing else, we should definitely line up the left edge of the dropdown
> with the left edge of the text above it.
Created attachment 136899 [details] [review]
Change the import button's label when the source is changed
This patch changes the label of the "Import Media Source" button as the user selects an import source. It also includes all the functionality required by dependent bugs to extend the ImportDialog.
All the dialog resizing this causes isn't good. We could try to reduce it by having shorter texts (eg just "Import" and "Choose") - but that won't work in every language. Maybe if we sized the dialog a fair bit wider than it currently is now it would work better? We could take advantage of the space to have a sentence for each importer type describing what it does?
Thoughts? Maybe we need an entirely different approach?
(In reply to comment #10)
> All the dialog resizing this causes isn't good. We could try to reduce it by
> having shorter texts (eg just "Import" and "Choose") - but that won't work in
> every language. Maybe if we sized the dialog a fair bit wider than it
> currently is now it would work better? We could take advantage of the space to
> have a sentence for each importer type describing what it does?
> Thoughts? Maybe we need an entirely different approach?
Frankly speaking, I like how previous patch works much more. The user sets all the data for the importer within the dialogue, and presses <Enter> to proceed with the import.
The current patch still makes it confusing: sometimes the default dialogue button starts another dialogue (file/folder chooser), sometimes it doesn't. More descriptive button text helps, but the interface is still not consistent.
I think consistency is more important than saving one mouse click.
Hrm, I'm now thinking the best option is a two step wizard. In step 1) you choose which import source, then click [Next].
In step 2) you get a FileChooserWidget and/or some checkboxes and/or some assuring text about what is about to happen, and click [Import]
Aaron, Alexander, et al: thoughts?
(In reply to comment #12)
> Hrm, I'm now thinking the best option is a two step wizard. In step 1) you
> choose which import source, then click [Next].
> In step 2) you get a FileChooserWidget and/or some checkboxes and/or some
> assuring text about what is about to happen, and click [Import]
> Aaron, Alexander, et al: thoughts?
I like the idea. I'm currently on holiday in another continent, I will update the patch in a week or two.
I wonder whether the wizard is really better than the previous version of the patch (from comment #5)
AFAIR the only reason it was discarded was to save a mouse click, but with the wizard we will have even more clicks than with what that patch does.
Also, most (if not all) importers have just a couple of options, having a dedicated dialog for them is IMHO an overkill.
Created attachment 138544 [details] [review]
Reverted last patch + fixes
This is actually the patch from comment #5 with these changes:
* Fixed alignment issue mentioned in comment #7
* Added a scroller to limit the size of the dialogue when a lot of files are selected.
* Now that git master can multi-select folders to import, the patch replaces the SelectFolderButton with the same set of controls as for the files.
* Minor fixes
Any suggestions on how the files/folders selection UI could be improved are welcome!
Created attachment 139443 [details]
Chat log from #ayatana on freenode
lamalex suggested to ask people on #ayatana, attached is the chat log.
Summary: djsiegel suggests to get rid of the import medial dialogue. The most common operation is importing from a folder, it should be presented as a menu item. Other importers should be in a submenu of "Import from...", e.g. Amarok, Rhythmbox, iTunes etc.
An open question is what to do with the file importer. Users definitely want to import individual files instead of folders but it seems the GtkFileChooserDialog cannot select both files *and* folders at the same time. On the other hand adding a new menu item for "Import Files" doesn't sound like a good idea.
djsiegel also suggested how to improve the existing dialogue, relevant messages:
(09:53:34) djsiegel1: alexkay: first of all, you guys repeat the window title bar in the window
(09:54:06) djsiegel1: I would change the text to "Choose an import source and click 'Import'"
(09:54:15) djsiegel1: and change the button to "Import"
(09:54:29) djsiegel1: you are calling them "import sources" and "media sources"
(09:55:17) djsiegel1: Maybe "Choose a source to import from:" and the import button could say "Next" ?
1. I think we should change "Home Directory" to "Home Folder"
2. Why do you define both install_widget_adapters and InstallWidgetAdapters and not just the latter?
3. I was surprised that when I selected a folder, it showed up, then I selected another folder, and instead of now having 2 folders selected, it replaced the original.
4. Idea for a small redesign for local folder/file dialog:
as-is, except below the horizontal divider, get rid of the grey "Import folders to library" text since it's redundant, instead put a "Browse..." button there, left aligned w/ the combobox above it, and immediately below that put the list of folders/files also left-aligned w/ the combobox
Created attachment 140563 [details] [review]
Same patch as before, except applies cleanly to master
Created attachment 140872 [details] [review]
Updated to comment #17
(In reply to comment #17)
> 1. I think we should change "Home Directory" to "Home Folder"
Fixed, though this breaks the string freeze.
> 2. Why do you define both install_widget_adapters and InstallWidgetAdapters and
> not just the latter?
install_widget_adapters is the underlying storage for the events and InstallWidgetAdapters is the public interface. It's the same code as in the PreferenceService.
> 3. I was surprised that when I selected a folder, it showed up, then I selected
> another folder, and instead of now having 2 folders selected, it replaced the
Appending to the list instead of replacing it makes sense, the user can always re-open the dialogue if she wants to start over. Fixed in this version of the patch.
> 4. Idea for a small redesign for local folder/file dialog:
> as-is, except below the horizontal divider, get rid of the grey "Import
> folders to library" text since it's redundant, instead put a "Browse..." button
> there, left aligned w/ the combobox above it, and immediately below that put
> the list of folders/files also left-aligned w/ the combobox
Created attachment 144449 [details] [review]
Add ImportLabel to all IImportSources
Alex, I think we're making this too complicated; I'm sorry for not reviewing things faster, and for changing my mind a few times now.
I think we should keep the import dialog mostly as is, and just improve it slightly by
1) Changing the default button text to "Import" and overriding it to "Choose Folders" and "Choose Files" for those two only
2) Fixing the dropdown/button alignment issue
3) Removing the dialog's Title as djsiegel mentioned
Attached is my first patch toward implementing these. I'd like Aaron to OK this idea before this is committed.
Created attachment 144450 [details] [review]
Actually use the ImportLabel in the dialog and remove the dialog's Title
I like these patches. Just a small nitpick, I think the "Chose Folders" and "Chose Files" buttons should get a mnemonic, e.g. "_F".
Also, while the patches fix the original problem, they don't address the dependent bugs: we still need to inject custom settings into the import dialogue. If you don't have principal objections against this feature, I can update my patch so that it applies on top of yours.
I'm actually rethinking the custom settings idea. I'm now thinking the 'Import ratings and play counts' wouldn't be that useful in this dialog. While we may have an issue with discoverability of the import settings (library location, copy-to-library, update-filenames, etc), I don't think putting them here is a good plan. It's harder, but I think will in the long term be better, to make those options more discoverable (maybe some first-run wizard).
Also, for the import-playcounts-and-ratings checkbox in particular, if a user imports some media w/ ratings they don't want, they can always select all in Recently Added and clear the rating (though atm they can't clear playcount; I'd be open to making it editable in the stats page/editor).
OK, that makes sense. What about the iTunes importer, should it still open a new dialog when the Import button is pressed, prompting for the iTunes library location and import settings?
All in all, I don't mind at all if your patches are committed, I will update the iTunes importer and the ratings/playcounts patch afterwards. I would really like to have them in 1.6, both features have been in development for too long IMHO.
Ok, I committed my patches.
If the iTunes migrator only has that one dialog with those couple prefs, then maybe we should put them into the import dialog itself. I haven't tried it in some time; doesn't it have another dialog or two that can popup depending on circumstances?
Bulk changing the assignee to firstname.lastname@example.org to make it easier for people to get updated on all banshee bugs by following that address. It's usually quite apparent who is working on a given bug by the comments and/or patches attached.
Created attachment 146373 [details]
Import dialog doesn't expand to title
I have just updated and it seems that the new import dialog doesn't expand well. I am attaching a screenshot in Spanish.
(In reply to comment #27)
> I have just updated and it seems that the new import dialog doesn't expand
> well. I am attaching a screenshot in Spanish.
Ok, can you update again? Should be fixed.
Just one more thing, there are two files that need to be added to POTFILES.in:
(In reply to comment #30)
> Just one more thing, there are two files that need to be added to POTFILES.in:
Fixed, thanks Benjamín!
I'm closing the bug as the original issue is now resolved. I added a comment in the other bug regarding the iTunes importer.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.