GNOME Bugzilla – Bug 559003
Merge "edit track information and track "properties" dialogs
Last modified: 2010-11-21 14:09:38 UTC
See summary. These dialogs are mostly the same and could as well be merged into one dialog that offers all functionality. This means the context menu for a track will be less cluttered. Hurray!
It looks like the Track Properties dialogue doesn't have anything that is not already in the Edit Track dialogue. I will make a patch that removes it.
They were purposefully split (though they're really exactly the same, just Properties only shows the read-only tabs). You need to convince Aaron (and probably Miguel) that removing the separate Properties option is a good thing before this will move forward. Alexander, I wouldn't waste your time on this until that happens.
Yep, I've noticed that the Banshee.Sources.Source class has these two propeties: HasViewableTrackProperties HasEditableTrackProperties ... and that eventually some sources could have only viewable properties (currently all sources have either both of them or neither of them). What if we show only the Edit Track menu in case when the source has both the viewable and the editable properties? It would fix this bug and will keep the Track Properties dialogue in place for future sources that have no editable properties. I'm going to attach the patch as I've already done this before seeing your comment, feel free to ignore it.
Created attachment 128950 [details] [review] Hide "Track Properties" menu item if "Edit Track" is visible.
*** Bug 561038 has been marked as a duplicate of this bug. ***
I don't really care too much about this, but you'll need to get Aaron's OK; I think he might care.
I disagree with this bug. I intentionally implemented it this way. It's all using the same dialog/logic, so there's no code duplication/bloat here FWIW. The main reason behind it is simply that "Properties" is a very common and expected item in a context menu to get information about an object. Having both items in the menu seems redundant, and probably is a bit, but they are separate discrete actions. Viewing Properties and Editing Metadata. Our context menu isn't that large anyway.
An excerpt from further discussion on IRC: (12:55:18) abock: final point on the edit/properties issue: usability wise, I think my approach has merit, but I am no usability expert; so if we have some real usability data to back up either approach, I'm all game for switching (or leaving it); I'm not game for changing what already exists because of personal preference alone (12:56:05) gabaug: abock: were you saying you do want to remove the read-only tabs from the Edit Track Info dialog? eg the 'Details' tab? (12:56:37) abock: no (12:56:43) abock: I had thought they weren't there (12:56:47) abock: but I am fine with it being there (12:56:49) gabaug: ok (12:56:54) abock: especially because that's the precedent (12:57:07) abock: so i am in favor of doing absolutely nothing :) I'm closing the bug for now, feel free to re-open.
*** Bug 628584 has been marked as a duplicate of this bug. ***
*** Bug 635424 has been marked as a duplicate of this bug. ***
I don't have anything against both menu items being there, but please, if you do leave them there do these two things: - Remove the "properties" tab from the "edit information dialogue". - Change the properties dialogue so it's not inside a tab. The current way both dialogues look make it seem that "properties" is a part of "track information" that for some reason or mistake got stranded and out of its place.