After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558942 - Dragging whitespace reveals secret contacts
Dragging whitespace reveals secret contacts
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
unspecified
Other Linux
: Normal minor
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2008-11-02 16:43 UTC by Jonny Lamb
Modified: 2011-07-26 08:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.32 KB, patch)
2011-07-20 07:23 UTC, Danielle Madeley 		none Details | Review

Description Jonny Lamb 2008-11-02 16:43:49 UTC 
1. Make sure there is whitespace at the bottom of your contact list.
2. Select a contact in your list.
3. Confirm that dragging the contact does the correct thing of dragging that contact.
4. Drag anywhere in the whitespace. The same selected contact is dragged for some reason.
Comment 1 Guillaume Desmottes 2009-01-18 20:21:29 UTC 
Can reproduce with 2.25.4
Comment 2 Mike Ruprecht 2010-01-29 22:24:09 UTC 
It seems that the contact dragged is the currently selected contact. If you start Empathy and immediately drag in whitespace (aka not select a contact first), the icon being dragged is not a contact.
Comment 3 Danielle Madeley 2011-07-20 07:23:49 UTC 
Created attachment 192274 [details] [review]
patch

This patch resolves the problem of the g_critical and the contact that appears even though no contact is selected. I'm not sure why you can drag out of white-space itself, I wonder if EmpathyIndividualView is doing something to break the drag-and-drop built into GtkTreeView (likely?). Need to dig into it more.
Comment 4 Xavier Claessens 2011-07-25 12:30:59 UTC 
Patch looks good. Please do the same in EmpathyContactListView. Yes we have too much code duplicated...
Comment 5 Danielle Madeley 2011-07-26 03:50:54 UTC 
Updated.
Comment 6 Xavier Claessens 2011-07-26 07:59:49 UTC 
I don't know where is your git branch, but I trust you updated. You can merge ;)
Comment 7 Xavier Claessens 2011-07-26 08:20:15 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.