GNOME Bugzilla – Bug 558690
Dia installs docs to ${datadir}/doc/dia regardless of --enable-gnome
Last modified: 2019-03-20 11:40:24 UTC
Please describe the problem: When you build Dia, and specify --enable-gnome, it should install documentation to /usr/share/gnome/help/dia. However regardless of this flag docdir remains being defined as /usr/share/doc/dia, and this is where docs get installed, As a result help->contents Always fails as it cannot locate help docs. Steps to reproduce: 1. Compile and instsall dia with "--enable-gnome" configuration option Actual results: Dia help docs are installed to /usr/share/doc/dia Expected results: They should be installed to /usr/share/gnome/help/dia when this compile option is specified. Does this happen every time? yes Other information: doc/Makefile.am does define "helpdir" and it changes based on --enable-gnome flag, but this variable is actually never used :( Possible solution would be to amend xmldocs.make to use helpdir instead of docdir ?
Created attachment 276041 [details] [review] gnome-doc.patch We are applying this patch for years to solve this, maybe could be included Thanks
Of course it could be included, but I have a hard time to understand why it is correlated to the issue at hand. To me it looks like only consmetic changes. e.g. - using AC_HELP_STRING instead of formatting with spaces - using yes/no instead of true/false - a more verbose version of saying not to Bonobo - using have_gnome instead of GNOME as state variable But maybe the last thing is more than just consmetic? Or is the extra AC_DEFINE(HAVE_GNOME,1,[Define if building with GNOME support]) the key to success. If so, shouldn't it repace the exisiting AC_DEFINE(GNOME,1,[Define if building with GNOME support]) instead of just adding another symbol?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/dia/issues/245.