After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558633 - Fixes for issues coming from the gio port
Fixes for issues coming from the gio port
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-31 06:07 UTC by Vincent Untz
Modified: 2009-04-29 19:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.84 KB, patch)
2008-10-31 06:08 UTC, Vincent Untz 		none Details | Review
Patch (2.29 KB, patch)
2008-11-29 19:22 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2008-10-31 06:07:17 UTC 
Here's a patch with a few fixes for issues introduced with the gio port (when loading HTML pages)
Comment 1 Vincent Untz 2008-10-31 06:08:38 UTC 
Created attachment 121714 [details] [review]
Patch

+ yelp_uri_resolve() didn't return an URI but a path in some case

+ window_do_load_html() was having fun converting an URI from a path to an URI

+ window_do_load_html() was looping while reading the HTML
Comment 2 Vincent Untz 2008-11-29 19:22:54 UTC 
Created attachment 123656 [details] [review]
Patch

Okay, the previous patch was wrong -- especially the change in yelp_uri_resolve(). It probably makes sense to rename uri to path in "type = yelp_uri_resolve (trace_uri, &real_uri, &frag_id);"
Comment 3 Vincent Untz 2009-03-06 17:32:01 UTC 
Ping. Note that a small part of the patch has been applied via bug 562137 (although I think the version in my patch is clearer...)
Comment 4 Don Scorgie 2009-04-29 19:44:44 UTC 
I'll trust you ;) .  Patch committed.

2009-04-29  Don Scorgie  <dscorgie@src.gnome.org>

	* src/yelp-window.c: 
	* src/yelp-utils.c: 
	Fix a series of issues resulting from the
	gio port (bug #558633 - patch by epic GNOME
	hero Vincent Untz)